Commit 1cdf3b28 authored by Caleb Sander Mateos's avatar Caleb Sander Mateos Committed by Jens Axboe
Browse files

selftests: ublk: add ublk auto integrity test 



The end-to-end integrity ublk selftest test_integrity_02 requires a
relatively recent fio version to support I/O with integrity buffers. Add
a version test_integrity_03 that uses the block layer's auto integrity
path instead. The auto integrity code doesn't check the application tag,
and doesn't indicate the bad guard/ref tag (just returns EILSEQ). But
it's a good smoke-test of the ublk integrity code and provides coverage
of the auto integrity path as well.

Signed-off-by: default avatarCaleb Sander Mateos <csander@purestorage.com>
Reviewed-by: default avatarMing Lei <tom.leiming@gmail.com>
Link: https://patch.msgid.link/20260421200901.1528842-4-csander@purestorage.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent eb3d1922

tools/testing/selftests/ublk/Makefile

+1 −0
Original line number Diff line number Diff line
@@ -37,6 +37,7 @@ TEST_PROGS += test_loop_07.sh 


TEST_PROGS += test_integrity_01.sh

TEST_PROGS += test_integrity_02.sh

TEST_PROGS += test_integrity_03.sh



TEST_PROGS += test_recover_01.sh

TEST_PROGS += test_recover_02.sh

tools/testing/selftests/ublk/test_integrity_03.sh

0 → 100755
+103 −0
Original line number Diff line number Diff line 
#!/bin/bash

# SPDX-License-Identifier: GPL-2.0



. "$(cd "$(dirname "$0")" && pwd)"/test_common.sh



if ! _have_program fio; then

	exit $UBLK_SKIP_CODE

fi



_test_fill_and_verify() {

	fio --name fill --rw randwrite $fio_args > /dev/null

	if [ $? != 0 ]; then

		echo "fio fill failed"

		ERR_CODE=255

		return 1

	fi



	fio --name verify --rw randread $fio_args > /dev/null

	if [ $? != 0 ]; then

		echo "fio verify failed"

		ERR_CODE=255

		return 1

	fi

}



_test_corrupted_reftag() {

	local dd_reftag_args="bs=1 seek=58 count=6 oflag=dsync conv=notrunc status=none"



	# Overwrite 6-byte reftag at offset 48 + 10 = 58

	dd if=/dev/urandom "of=${UBLK_BACKFILES[1]}" $dd_reftag_args

	if [ $? != 0 ]; then

		echo "dd corrupted_reftag failed"

		ERR_CODE=255

		return 1

	fi



	if fio --name corrupted_reftag --rw randread $fio_args > /dev/null 2> "$fio_err"; then

		echo "fio corrupted_reftag unexpectedly succeeded"

		ERR_CODE=255

		return 1

	fi



	if ! grep -q "$expected_err" "$fio_err"; then

		echo "fio corrupted_reftag message not found: $expected_err"

		ERR_CODE=255

		return 1

	fi



	# Reset to 0

	dd if=/dev/zero "of=${UBLK_BACKFILES[1]}" $dd_reftag_args

	if [ $? != 0 ]; then

		echo "dd restore corrupted_reftag failed"

		ERR_CODE=255

		return 1

	fi

}



_test_corrupted_data() {

	local dd_data_args="bs=512 count=1 oflag=direct,dsync conv=notrunc status=none"



	dd if=/dev/zero "of=${UBLK_BACKFILES[0]}" $dd_data_args

	if [ $? != 0 ]; then

		echo "dd corrupted_data failed"

		ERR_CODE=255

		return 1

	fi



	if fio --name corrupted_data --rw randread $fio_args > /dev/null 2> "$fio_err"; then

		echo "fio corrupted_data unexpectedly succeeded"

		ERR_CODE=255

		return 1

	fi



	if ! grep -q "$expected_err" "$fio_err"; then

		echo "fio corrupted_data message not found: $expected_err"

		ERR_CODE=255

		return 1

	fi

}



_prep_test "loop" "end-to-end auto integrity"



_create_backfile 0 256M

_create_backfile 1 32M # 256M * (64 integrity bytes / 512 data bytes)

integrity_params="--integrity_capable --integrity_reftag

		  --metadata_size 64 --pi_offset 48 --csum_type nvme"

dev_id=$(_add_ublk_dev -t loop -u $integrity_params "${UBLK_BACKFILES[@]}")

_check_add_dev "$TID" $?



fio_args="--ioengine libaio --direct 1 --bsrange 512-1M --iodepth 32

	  --filename /dev/ublkb$dev_id"

fio_err=$(mktemp "${UBLK_TEST_DIR}"/fio_err_XXXXX)

ERR_CODE=0



expected_err="Invalid or incomplete multibyte or wide character: read offset=0"

_test_fill_and_verify && \

_test_corrupted_reftag && \

_test_corrupted_data



rm -f "$fio_err"



_cleanup_test

_show_result "$TID" $ERR_CODE