Commit 1ce2292c authored by Kinsey Ho's avatar Kinsey Ho Committed by Andrew Morton
Browse files

mm/mglru: drop unused parameter 

Patch series "mm/mglru: code cleanup and refactoring"

This provides MGLRU code cleanup and refactoring for better readability.


This patch (of 5):

struct scan_control *sc is currently passed into try_to_inc_max_seq() and
run_aging().  This parameter is not used.

Drop the unused parameter struct scan_control *sc. No functional change.

Link: https://lkml.kernel.org/r/20240214060538.3524462-1-kinseyho@google.com
Link: https://lkml.kernel.org/r/20240214060538.3524462-2-kinseyho@google.com


Signed-off-by: default avatarKinsey Ho <kinseyho@google.com>
Cc: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
Cc: Donet Tom <donettom@linux.vnet.ibm.com>
Cc: Yu Zhao <yuzhao@google.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent e10aea10

mm/vmscan.c

+5 −5
Original line number Diff line number Diff line
@@ -3816,7 +3816,7 @@ static bool inc_max_seq(struct lruvec *lruvec, unsigned long max_seq, 
}



static bool try_to_inc_max_seq(struct lruvec *lruvec, unsigned long max_seq,

			       struct scan_control *sc, bool can_swap, bool force_scan)

			       bool can_swap, bool force_scan)

{

	bool success;

	struct lru_gen_mm_walk *walk;
@@ -4672,7 +4672,7 @@ static long get_nr_to_scan(struct lruvec *lruvec, struct scan_control *sc, bool 
		return nr_to_scan;



	/* skip this lruvec as it's low on cold folios */

	return try_to_inc_max_seq(lruvec, max_seq, sc, can_swap, false) ? -1 : 0;

	return try_to_inc_max_seq(lruvec, max_seq, can_swap, false) ? -1 : 0;

}



static bool should_abort_scan(struct lruvec *lruvec, struct scan_control *sc)
@@ -5332,7 +5332,7 @@ static const struct seq_operations lru_gen_seq_ops = { 
	.show = lru_gen_seq_show,

};



static int run_aging(struct lruvec *lruvec, unsigned long seq, struct scan_control *sc,

static int run_aging(struct lruvec *lruvec, unsigned long seq,

		     bool can_swap, bool force_scan)

{

	DEFINE_MAX_SEQ(lruvec);
@@ -5347,7 +5347,7 @@ static int run_aging(struct lruvec *lruvec, unsigned long seq, struct scan_contr 
	if (!force_scan && min_seq[!can_swap] + MAX_NR_GENS - 1 <= max_seq)

		return -ERANGE;



	try_to_inc_max_seq(lruvec, max_seq, sc, can_swap, force_scan);

	try_to_inc_max_seq(lruvec, max_seq, can_swap, force_scan);



	return 0;

}
@@ -5415,7 +5415,7 @@ static int run_cmd(char cmd, int memcg_id, int nid, unsigned long seq, 


	switch (cmd) {

	case '+':

		err = run_aging(lruvec, seq, sc, swappiness, opt);

		err = run_aging(lruvec, seq, swappiness, opt);

		break;

	case '-':

		err = run_eviction(lruvec, seq, sc, swappiness, opt);