Commit 1cefe495 authored by Rafael J. Wysocki's avatar Rafael J. Wysocki
Browse files

cpufreq: intel_pstate: Always use HWP_DESIRED_PERF in passive mode 



In the passive mode, intel_cpufreq_update_pstate() sets HWP_MIN_PERF in
accordance with the target frequency to ensure delivering adequate
performance, but it sets HWP_DESIRED_PERF to 0, so the processor has no
indication that the desired performance level is actually equal to the
floor one.  This may cause it to choose a performance point way above
the desired level.

Moreover, this is inconsistent with intel_cpufreq_adjust_perf() which
actually sets HWP_DESIRED_PERF in accordance with the target performance
value.

Address this by adjusting intel_cpufreq_update_pstate() to pass
target_pstate as both the minimum and the desired performance levels
to intel_cpufreq_hwp_update().

Fixes: a365ab6b ("cpufreq: intel_pstate: Implement the ->adjust_perf() callback")
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tested-by: default avatarShashank Balaji <shashank.mahadasyam@sony.com>
Link: https://patch.msgid.link/6173276.lOV4Wx5bFT@rjwysocki.net
parent 221504a6

drivers/cpufreq/intel_pstate.c

+2 −2
Original line number Diff line number Diff line
@@ -3249,8 +3249,8 @@ static int intel_cpufreq_update_pstate(struct cpufreq_policy *policy, 
		int max_pstate = policy->strict_target ?

					target_pstate : cpu->max_perf_ratio;



		intel_cpufreq_hwp_update(cpu, target_pstate, max_pstate, 0,

					 fast_switch);

		intel_cpufreq_hwp_update(cpu, target_pstate, max_pstate,

					 target_pstate, fast_switch);

	} else if (target_pstate != old_pstate) {

		intel_cpufreq_perf_ctl_update(cpu, target_pstate, fast_switch);

	}