Commit 1d3062fa authored by Tomi Valkeinen's avatar Tomi Valkeinen
Browse files

drm/drm_file: fix use of uninitialized variable 



smatch reports:

drivers/gpu/drm/drm_file.c:967 drm_show_memory_stats() error: uninitialized symbol 'supported_status'.

'supported_status' is only set in one code path. I'm not familiar with
the code to say if that path will always be ran in real life, but
whether that is the case or not, I think it is good to initialize
'supported_status' to 0 to silence the warning (and possibly fix a bug).

Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Acked-by: default avatarMaxime Ripard <mripard@kernel.org>
Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20231103-uninit-fixes-v2-1-c22b2444f5f5@ideasonboard.com
parent 28d3d069

drivers/gpu/drm/drm_file.c

+1 −1
Original line number Diff line number Diff line
@@ -898,7 +898,7 @@ void drm_show_memory_stats(struct drm_printer *p, struct drm_file *file) 
{

	struct drm_gem_object *obj;

	struct drm_memory_stats status = {};

	enum drm_gem_object_status supported_status;

	enum drm_gem_object_status supported_status = 0;

	int id;



	spin_lock(&file->table_lock);