Commit 1d3eb44a authored by Ricardo Ribalda's avatar Ricardo Ribalda Committed by Mauro Carvalho Chehab
Browse files

media: stk1160: Use min macro 

Instead of a custom min() implementation, use the real macro.

Mitigates the following cocci WARNINGs:
drivers/media/usb/stk1160/stk1160-video.c:133:12-13: WARNING opportunity for min()
drivers/media/usb/stk1160/stk1160-video.c:176:13-14: WARNING opportunity for min()

Link: https://lore.kernel.org/linux-media/20240429-fix-cocci-v3-19-3c4865f5a4b0@chromium.org


Reviewed-by: default avatarBryan O'Donoghue <bryan.odonoghue@linaro.org>
Signed-off-by: default avatarRicardo Ribalda <ribalda@chromium.org>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
parent 45fbce19

drivers/media/usb/stk1160/stk1160-video.c

+2 −8
Original line number Diff line number Diff line
@@ -130,10 +130,7 @@ void stk1160_copy_video(struct stk1160 *dev, u8 *src, int len) 
	dst += linesdone * bytesperline * 2 + lineoff;



	/* Copy the remaining of current line */

	if (remain < (bytesperline - lineoff))

		lencopy = remain;

	else

		lencopy = bytesperline - lineoff;

	lencopy = min(remain, bytesperline - lineoff);



	/*

	 * Check if we have enough space left in the buffer.
@@ -178,10 +175,7 @@ void stk1160_copy_video(struct stk1160 *dev, u8 *src, int len) 
		src += lencopy;



		/* Copy one line at a time */

		if (remain < bytesperline)

			lencopy = remain;

		else

			lencopy = bytesperline;

		lencopy = min(remain, bytesperline);



		/*

		 * Check if we have enough space left in the buffer.