Unverified Commit 1d43dddd authored by José Expósito's avatar José Expósito Committed by Louis Chauvet
Browse files

drm/vkms: Drop unnecessary call to drm_crtc_cleanup() 



CRTC creation uses drmm_crtc_init_with_planes(), which automatically
handles cleanup. However, an unnecessary call to drm_crtc_cleanup() is
still present in the vkms_output_init() error path.

Fixes: 99cc528e ("drm/vkms: Use drmm_crtc_init_with_planes()")
Signed-off-by: default avatarJosé Expósito <jose.exposito89@gmail.com>
Reviewed-by: default avatarMaíra Canal <mcanal@igalia.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241031183835.3633-1-jose.exposito89@gmail.com


Acked-by: default avatarLouis Chauvet <louis.chauvet@bootlin.com>
Signed-off-by: default avatarLouis Chauvet <louis.chauvet@bootlin.com>
parent 89115aee

drivers/gpu/drm/vkms/vkms_output.c

+1 −4
Original line number Diff line number Diff line
@@ -92,7 +92,7 @@ int vkms_output_init(struct vkms_device *vkmsdev, int index) 
				 DRM_MODE_CONNECTOR_VIRTUAL);

	if (ret) {

		DRM_ERROR("Failed to init connector\n");

		goto err_connector;

		return ret;

	}



	drm_connector_helper_add(connector, &vkms_conn_helper_funcs);
@@ -131,8 +131,5 @@ int vkms_output_init(struct vkms_device *vkmsdev, int index) 
err_encoder:

	drm_connector_cleanup(connector);



err_connector:

	drm_crtc_cleanup(crtc);



	return ret;

}