Commit 1d5c6951 authored by Dan Carpenter's avatar Dan Carpenter Committed by Leon Romanovsky
Browse files

RDMA/mana_ib: Use safer allocation function() 



My static checker says this multiplication can overflow.  I'm not an
expert in this code but the call tree would be:

ib_uverbs_handler_UVERBS_METHOD_QP_CREATE() <- reads cap from the user
-> ib_create_qp_user()
   -> create_qp()
      -> mana_ib_create_qp()
         -> mana_ib_create_ud_qp()
            -> create_shadow_queue()

It can't hurt to use safer interfaces.

Fixes: c8017f5b ("RDMA/mana_ib: UD/GSI work requests")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Link: https://patch.msgid.link/58439ac0-1ee5-4f96-a595-7ab83b59139b@stanley.mountain


Reviewed-by: default avatarLong Li <longli@microsoft.com>
Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
parent 98cf1d1a

drivers/infiniband/hw/mana/shadow_queue.h

+1 −1
Original line number Diff line number Diff line
@@ -40,7 +40,7 @@ struct shadow_queue { 


static inline int create_shadow_queue(struct shadow_queue *queue, uint32_t length, uint32_t stride)

{

	queue->buffer = kvmalloc(length * stride, GFP_KERNEL);

	queue->buffer = kvmalloc_array(length, stride, GFP_KERNEL);

	if (!queue->buffer)

		return -ENOMEM;