Commit 1d86d946 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Hans de Goede
Browse files

platform/x86: quickstart: Miscellaneous improvements 



There is a mix of a few improvements to the driver.
I have done this instead of review, so it can quickly be
folded into the original code (partially or fully).

Signed-off-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Reviewed-by: default avatarArmin Wolf <W_Armin@gmx.de>
Link: https://lore.kernel.org/r/20240327215208.649020-1-andy.shevchenko@gmail.com


Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent 609bf4bd

drivers/platform/x86/quickstart.c

+10 −6
Original line number Diff line number Diff line 
// SPDX-License-Identifier: GPL-2.0-or-later

/*

 * quickstart.c - ACPI Direct App Launch driver

 * ACPI Direct App Launch driver

 *

 * Copyright (C) 2024 Armin Wolf <W_Armin@gmx.de>

 * Copyright (C) 2022 Arvid Norlander <lkml@vorapal.se>
@@ -10,15 +10,18 @@ 
 * <https://archive.org/details/microsoft-acpi-dirapplaunch>

 */



#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt



#include <linux/acpi.h>

#include <linux/device.h>

#include <linux/errno.h>

#include <linux/init.h>

#include <linux/input.h>

#include <linux/input/sparse-keymap.h>

#include <linux/kernel.h>

#include <linux/mod_devicetable.h>

#include <linux/module.h>

#include <linux/platform_device.h>

#include <linux/pm_wakeup.h>

#include <linux/printk.h>

#include <linux/slab.h>

#include <linux/sysfs.h>

#include <linux/types.h>
@@ -165,7 +168,8 @@ static int quickstart_probe(struct platform_device *pdev) 
	data->dev = &pdev->dev;

	dev_set_drvdata(&pdev->dev, data);



	/* We have to initialize the device wakeup before evaluating GHID because

	/*

	 * We have to initialize the device wakeup before evaluating GHID because

	 * doing so will notify the device if the button was used to wake the machine

	 * from S5.

	 */
@@ -202,7 +206,7 @@ static int quickstart_probe(struct platform_device *pdev) 
}



static const struct acpi_device_id quickstart_device_ids[] = {

	{ "PNP0C32", 0 },

	{ "PNP0C32" },

	{ }

};

MODULE_DEVICE_TABLE(acpi, quickstart_device_ids);