Commit 1d9622c3 authored by Ian Rogers's avatar Ian Rogers Committed by Arnaldo Carvalho de Melo
Browse files

perf tests: Additional 'perf stat' tests 

Recently 'perf stat' regressed in per CPU mode [1].

Let's expand test coverage to catch the same breakage again as well as
to test the repeat, pid, detailed and no aggregation options.

[1] https://lore.kernel.org/linux-perf-users/cgja46br2smmznxs7kbeabs6zgv3b4olfqgh2fdp5mxk2yom4v@w6jjgov6hdi6/



Signed-off-by: default avatarIan Rogers <irogers@google.com>
Tested-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: James Clark <james.clark@linaro.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Richter <tmricht@linux.ibm.com>
Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent a108a6a4

tools/perf/tests/shell/stat.sh

+242 −0
Original line number Diff line number Diff line
@@ -5,6 +5,21 @@ 
set -e



err=0

stat_output=$(mktemp /tmp/perf-stat-test-output.XXXXX)



cleanup() {

  rm -f "${stat_output}"

  trap - EXIT TERM INT

}



trap_cleanup() {

  echo "Unexpected signal in ${FUNCNAME[1]}"

  cleanup

  exit 1

}



trap trap_cleanup EXIT TERM INT



test_default_stat() {

  echo "Basic stat command test"

  if ! perf stat true 2>&1 | grep -E -q "Performance counter stats for 'true':"
@@ -248,6 +263,226 @@ test_hybrid() { 
  echo "hybrid test [Success]"

}



test_stat_cpu() {

  echo "stat -C <cpu> test"

  # Test the full online CPU list (ranges and lists)

  online_cpus=$(cat /sys/devices/system/cpu/online)

  if ! perf stat -C "$online_cpus" -a true > "${stat_output}" 2>&1

  then

    echo "stat -C <cpu> test [Failed - command failed for cpus $online_cpus]"

    cat "${stat_output}"

    err=1

    return

  fi



  if ! grep -E -q "Performance counter stats for" "${stat_output}"

  then

    echo "stat -C <cpu> test [Failed - missing output for cpus $online_cpus]"

    cat "${stat_output}"

    err=1

    return

  fi



  # Test each individual online CPU

  for cpu_dir in /sys/devices/system/cpu/cpu[0-9]*; do

    cpu=${cpu_dir##*/cpu}

    # Check if online

    if [ -f "$cpu_dir/online" ] && [ "$(cat "$cpu_dir/online")" -eq 0 ]

    then

      continue

    fi



    if ! perf stat -C "$cpu" -a true > "${stat_output}" 2>&1

    then

      echo "stat -C <cpu> test [Failed - command failed for cpu $cpu]"

      cat "${stat_output}"

      err=1

      return

    fi

    if ! grep -E -q "Performance counter stats for" "${stat_output}"

    then

      echo "stat -C <cpu> test [Failed - missing output for cpu $cpu]"

      cat "${stat_output}"

      err=1

      return

    fi

  done



  # Test synthetic list and range if cpu0 and cpu1 are online

  c0_online=0

  c1_online=0

  if [ -d "/sys/devices/system/cpu/cpu0" ]

  then

    if [ ! -f "/sys/devices/system/cpu/cpu0/online" ] || [ "$(cat /sys/devices/system/cpu/cpu0/online)" -eq 1 ]

    then

      c0_online=1

    fi

  fi

  if [ -d "/sys/devices/system/cpu/cpu1" ]

  then

    if [ ! -f "/sys/devices/system/cpu/cpu1/online" ] || [ "$(cat /sys/devices/system/cpu/cpu1/online)" -eq 1 ]

    then

      c1_online=1

    fi

  fi



  if [ $c0_online -eq 1 ] && [ $c1_online -eq 1 ]

  then

    # Test list "0,1"

    if ! perf stat -C "0,1" -a true > "${stat_output}" 2>&1

    then

      echo "stat -C <cpu> test [Failed - command failed for cpus 0,1]"

      cat "${stat_output}"

      err=1

      return

    fi

    if ! grep -E -q "Performance counter stats for" "${stat_output}"

    then

      echo "stat -C <cpu> test [Failed - missing output for cpus 0,1]"

      cat "${stat_output}"

      err=1

      return

    fi



    # Test range "0-1"

    if ! perf stat -C "0-1" -a true > "${stat_output}" 2>&1

    then

      echo "stat -C <cpu> test [Failed - command failed for cpus 0-1]"

      cat "${stat_output}"

      err=1

      return

    fi

    if ! grep -E -q "Performance counter stats for" "${stat_output}"

    then

      echo "stat -C <cpu> test [Failed - missing output for cpus 0-1]"

      cat "${stat_output}"

      err=1

      return

    fi

  fi



  echo "stat -C <cpu> test [Success]"

}



test_stat_no_aggr() {

  echo "stat -A test"

  if ! perf stat -A -a true > "${stat_output}" 2>&1

  then

    echo "stat -A test [Failed - command failed]"

    cat "${stat_output}"

    err=1

    return

  fi



  if ! grep -E -q "CPU" "${stat_output}"

  then

    echo "stat -A test [Failed - missing CPU column]"

    cat "${stat_output}"

    err=1

    return

  fi

  echo "stat -A test [Success]"

}



test_stat_detailed() {

  echo "stat -d test"

  if ! perf stat -d true > "${stat_output}" 2>&1

  then

    echo "stat -d test [Failed - command failed]"

    cat "${stat_output}"

    err=1

    return

  fi



  if ! grep -E -q "Performance counter stats" "${stat_output}"

  then

    echo "stat -d test [Failed - missing output]"

    cat "${stat_output}"

    err=1

    return

  fi



  if ! perf stat -dd true > "${stat_output}" 2>&1

  then

    echo "stat -dd test [Failed - command failed]"

    cat "${stat_output}"

    err=1

    return

  fi



  if ! grep -E -q "Performance counter stats" "${stat_output}"

  then

    echo "stat -dd test [Failed - missing output]"

    cat "${stat_output}"

    err=1

    return

  fi



  if ! perf stat -ddd true > "${stat_output}" 2>&1

  then

    echo "stat -ddd test [Failed - command failed]"

    cat "${stat_output}"

    err=1

    return

  fi



  if ! grep -E -q "Performance counter stats" "${stat_output}"

  then

    echo "stat -ddd test [Failed - missing output]"

    cat "${stat_output}"

    err=1

    return

  fi



  echo "stat -d test [Success]"

}



test_stat_repeat() {

  echo "stat -r test"

  if ! perf stat -r 2 true > "${stat_output}" 2>&1

  then

    echo "stat -r test [Failed - command failed]"

    cat "${stat_output}"

    err=1

    return

  fi



  if ! grep -E -q "\([[:space:]]*\+-.*%[[:space:]]*\)" "${stat_output}"

  then

    echo "stat -r test [Failed - missing variance]"

    cat "${stat_output}"

    err=1

    return

  fi

  echo "stat -r test [Success]"

}



test_stat_pid() {

  echo "stat -p test"

  sleep 1 &

  pid=$!

  if ! perf stat -p $pid > "${stat_output}" 2>&1

  then

    echo "stat -p test [Failed - command failed]"

    cat "${stat_output}"

    err=1

    kill $pid 2>/dev/null || true

    wait $pid 2>/dev/null || true

    return

  fi



  if ! grep -E -q "Performance counter stats" "${stat_output}"

  then

    echo "stat -p test [Failed - missing output]"

    cat "${stat_output}"

    err=1

  else

    echo "stat -p test [Success]"

  fi

  kill $pid 2>/dev/null || true

  wait $pid 2>/dev/null || true

}



test_default_stat

test_null_stat

test_offline_cpu_stat
@@ -258,4 +493,11 @@ test_topdown_groups 
test_topdown_weak_groups

test_cputype

test_hybrid

test_stat_cpu

test_stat_no_aggr

test_stat_detailed

test_stat_repeat

test_stat_pid



cleanup

exit $err