Commit 1da2dca2 authored by Dmitry Antipov's avatar Dmitry Antipov Committed by Greg Kroah-Hartman
Browse files

binder: use kstrdup() in binderfs_binder_device_create() 



In 'binderfs_binder_device_create()', use 'kstrdup()' to copy the
newly created device's name, thus making the former a bit simpler.

Signed-off-by: default avatarDmitry Antipov <dmantipov@yandex.ru>
Acked-by: default avatarCarlos Llamas <cmllamas@google.com>
Reviewed-by: default avatar"Tiffany Y. Yang" <ynaffit@google.com>
Reviewed-by: default avatarAlice Ryhl <aliceryhl@google.com>
Link: https://lore.kernel.org/r/20250626073054.7706-1-dmantipov@yandex.ru


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent db15ec7a

drivers/android/binderfs.c

+1 −4
Original line number Diff line number Diff line
@@ -117,7 +117,6 @@ static int binderfs_binder_device_create(struct inode *ref_inode, 
	struct dentry *dentry, *root;

	struct binder_device *device;

	char *name = NULL;

	size_t name_len;

	struct inode *inode = NULL;

	struct super_block *sb = ref_inode->i_sb;

	struct binderfs_info *info = sb->s_fs_info;
@@ -161,9 +160,7 @@ static int binderfs_binder_device_create(struct inode *ref_inode, 
	inode->i_gid = info->root_gid;



	req->name[BINDERFS_MAX_NAME] = '\0'; /* NUL-terminate */

	name_len = strlen(req->name);

	/* Make sure to include terminating NUL byte */

	name = kmemdup(req->name, name_len + 1, GFP_KERNEL);

	name = kstrdup(req->name, GFP_KERNEL);

	if (!name)

		goto err;