Commit 1e15a680 authored by Troy Mitchell's avatar Troy Mitchell Committed by Alexandre Belloni
Browse files

rtc: pcf8563: fix wrong alarm register 



When the regmap framework was introduced to this driver,
the PCF8563_REG_AMN register within the set_alarm function was
incorrectly changed to PCF8563_REG_SC.

The PCF8563_REG_SC register is the seconds register.
This caused alarm values to be written to the seconds register
when an alarm was set. Which means the alarm would not trigger
as expected and the seconds register would be overwritten
with an incorrect value.

Signed-off-by: default avatarTroy Mitchell <troymitchell988@gmail.com>
Link: https://lore.kernel.org/r/20250531-pcf8563-fix-alarm-v2-1-cac4b1716167@gmail.com


Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent f096bdbf

drivers/rtc/rtc-pcf8563.c

+1 −1
Original line number Diff line number Diff line
@@ -285,7 +285,7 @@ static int pcf8563_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *tm) 
	buf[2] = bin2bcd(tm->time.tm_mday);

	buf[3] = tm->time.tm_wday & 0x07;



	err = regmap_bulk_write(pcf8563->regmap, PCF8563_REG_SC, buf,

	err = regmap_bulk_write(pcf8563->regmap, PCF8563_REG_AMN, buf,

				sizeof(buf));

	if (err)

		return err;