Commit 1e1b6dbc authored by Eric Biggers's avatar Eric Biggers
Browse files

arm/crc32: expose CRC32 functions through lib 



Move the arm CRC32 assembly code into the lib directory and wire it up
to the library interface.  This allows it to be used without going
through the crypto API.  It remains usable via the crypto API too via
the shash algorithms that use the library interface.  Thus all the
arch-specific "shash" code becomes unnecessary and is removed.

Note: to see the diff from arch/arm/crypto/crc32-ce-glue.c to
arch/arm/lib/crc32-glue.c, view this commit with 'git show -M10'.

Reviewed-by: default avatarArd Biesheuvel <ardb@kernel.org>
Link: https://lore.kernel.org/r/20241202010844.144356-6-ebiggers@kernel.org


Signed-off-by: default avatarEric Biggers <ebiggers@google.com>
parent 780acb25

arch/arm/Kconfig

+1 −0
Original line number Diff line number Diff line
@@ -7,6 +7,7 @@ config ARM 
	select ARCH_HAS_BINFMT_FLAT

	select ARCH_HAS_CPU_CACHE_ALIASING

	select ARCH_HAS_CPU_FINALIZE_INIT if MMU

	select ARCH_HAS_CRC32 if KERNEL_MODE_NEON

	select ARCH_HAS_CURRENT_STACK_POINTER

	select ARCH_HAS_DEBUG_VIRTUAL if MMU

	select ARCH_HAS_DMA_ALLOC if MMU

arch/arm/configs/milbeaut_m10v_defconfig

+0 −1
Original line number Diff line number Diff line
@@ -107,7 +107,6 @@ CONFIG_CRYPTO_AES_ARM=m 
CONFIG_CRYPTO_AES_ARM_BS=m

CONFIG_CRYPTO_AES_ARM_CE=m

CONFIG_CRYPTO_CHACHA20_NEON=m

CONFIG_CRYPTO_CRC32_ARM_CE=m

# CONFIG_CRYPTO_HW is not set

CONFIG_CRC_CCITT=m

CONFIG_CRC_ITU_T=m

arch/arm/configs/multi_v7_defconfig

+0 −1
Original line number Diff line number Diff line
@@ -1306,7 +1306,6 @@ CONFIG_CRYPTO_AES_ARM=m 
CONFIG_CRYPTO_AES_ARM_BS=m

CONFIG_CRYPTO_AES_ARM_CE=m

CONFIG_CRYPTO_CHACHA20_NEON=m

CONFIG_CRYPTO_CRC32_ARM_CE=m

CONFIG_CRYPTO_DEV_SUN4I_SS=m

CONFIG_CRYPTO_DEV_FSL_CAAM=m

CONFIG_CRYPTO_DEV_EXYNOS_RNG=m

arch/arm/crypto/Kconfig

+0 −14
Original line number Diff line number Diff line
@@ -222,20 +222,6 @@ config CRYPTO_CHACHA20_NEON 
	  Architecture: arm using:

	  - NEON (Advanced SIMD) extensions



config CRYPTO_CRC32_ARM_CE

	tristate "CRC32C and CRC32"

	depends on KERNEL_MODE_NEON

	depends on CRC32

	select CRYPTO_HASH

	help

	  CRC32c CRC algorithm with the iSCSI polynomial (RFC 3385 and RFC 3720)

	  and CRC32 CRC algorithm (IEEE 802.3)



	  Architecture: arm using:

	  - CRC and/or PMULL instructions



	  Drivers: crc32-arm-ce and crc32c-arm-ce



config CRYPTO_CRCT10DIF_ARM_CE

	tristate "CRCT10DIF"

	depends on KERNEL_MODE_NEON

arch/arm/crypto/Makefile

+0 −2
Original line number Diff line number Diff line
@@ -21,7 +21,6 @@ obj-$(CONFIG_CRYPTO_SHA1_ARM_CE) += sha1-arm-ce.o 
obj-$(CONFIG_CRYPTO_SHA2_ARM_CE) += sha2-arm-ce.o

obj-$(CONFIG_CRYPTO_GHASH_ARM_CE) += ghash-arm-ce.o

obj-$(CONFIG_CRYPTO_CRCT10DIF_ARM_CE) += crct10dif-arm-ce.o

obj-$(CONFIG_CRYPTO_CRC32_ARM_CE) += crc32-arm-ce.o



aes-arm-y	:= aes-cipher-core.o aes-cipher-glue.o

aes-arm-bs-y	:= aes-neonbs-core.o aes-neonbs-glue.o
@@ -38,7 +37,6 @@ sha2-arm-ce-y := sha2-ce-core.o sha2-ce-glue.o 
aes-arm-ce-y	:= aes-ce-core.o aes-ce-glue.o

ghash-arm-ce-y	:= ghash-ce-core.o ghash-ce-glue.o

crct10dif-arm-ce-y	:= crct10dif-ce-core.o crct10dif-ce-glue.o

crc32-arm-ce-y:= crc32-ce-core.o crc32-ce-glue.o

chacha-neon-y := chacha-scalar-core.o chacha-glue.o

chacha-neon-$(CONFIG_KERNEL_MODE_NEON) += chacha-neon-core.o

poly1305-arm-y := poly1305-core.o poly1305-glue.o