Commit 1e5a5414 authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Paolo Abeni
Browse files

net: phy: mediatek: fix nvmem cell reference leak in mt798x_phy_calibration 



When nvmem_cell_read() fails in mt798x_phy_calibration(), the function
returns without calling nvmem_cell_put(), leaking the cell reference.

Move nvmem_cell_put() right after nvmem_cell_read() to ensure the cell
reference is always released regardless of the read result.

Found via static analysis and code review.

Fixes: 98c485ea ("net: phy: add driver for MediaTek SoC built-in GE PHYs")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Reviewed-by: default avatarDaniel Golle <daniel@makrotopia.org>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/20251211081313.2368460-1-linmq006@gmail.com


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 15ef641a

drivers/net/phy/mediatek/mtk-ge-soc.c

+1 −1
Original line number Diff line number Diff line
@@ -1167,9 +1167,9 @@ static int mt798x_phy_calibration(struct phy_device *phydev) 
	}



	buf = (u32 *)nvmem_cell_read(cell, &len);

	nvmem_cell_put(cell);

	if (IS_ERR(buf))

		return PTR_ERR(buf);

	nvmem_cell_put(cell);



	if (!buf[0] || !buf[1] || !buf[2] || !buf[3] || len < 4 * sizeof(u32)) {

		phydev_err(phydev, "invalid efuse data\n");