Commit 1e5e40f2 authored by Dan Carpenter's avatar Dan Carpenter Committed by Jakub Kicinski
Browse files

net: airoha: Fix a NULL vs IS_ERR() bug in airoha_npu_run_firmware() 



The devm_ioremap_resource() function returns error pointers.  It never
returns NULL.  Update the check to match.

Fixes: e27dba19 ("net: Use of_reserved_mem_region_to_resource{_byname}() for "memory-region"")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Acked-by: default avatarLorenzo Bianconi <lorenzo@kernel.org>
Link: https://patch.msgid.link/fc6d194e-6bf5-49ca-bc77-3fdfda62c434@sabinyo.mountain


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 687678f1

drivers/net/ethernet/airoha/airoha_npu.c

+2 −2
Original line number Diff line number Diff line
@@ -179,8 +179,8 @@ static int airoha_npu_run_firmware(struct device *dev, void __iomem *base, 
	}



	addr = devm_ioremap_resource(dev, res);

	if (!addr) {

		ret = -ENOMEM;

	if (IS_ERR(addr)) {

		ret = PTR_ERR(addr);

		goto out;

	}