Commit 1e6e7602 authored by Pavel Begunkov's avatar Pavel Begunkov Committed by Jens Axboe
Browse files

io_uring: kill io_llist_xchg 



io_llist_xchg is only used to set the list to NULL, which can also be
done with llist_del_all(). Use the latter and kill io_llist_xchg.

Signed-off-by: default avatarPavel Begunkov <asml.silence@gmail.com>
Link: https://lore.kernel.org/r/d6765112680d2e86a58b76166b7513391ff4e5d7.1729264960.git.asml.silence@gmail.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent b6b3eb19

io_uring/io_uring.c

+1 −15
Original line number Diff line number Diff line
@@ -1081,20 +1081,6 @@ struct llist_node *io_handle_tw_list(struct llist_node *node, 
	return node;

}



/**

 * io_llist_xchg - swap all entries in a lock-less list

 * @head:	the head of lock-less list to delete all entries

 * @new:	new entry as the head of the list

 *

 * If list is empty, return NULL, otherwise, return the pointer to the first entry.

 * The order of entries returned is from the newest to the oldest added one.

 */

static inline struct llist_node *io_llist_xchg(struct llist_head *head,

					       struct llist_node *new)

{

	return xchg(&head->first, new);

}



static __cold void io_fallback_tw(struct io_uring_task *tctx, bool sync)

{

	struct llist_node *node = llist_del_all(&tctx->task_list);
@@ -1316,7 +1302,7 @@ static int __io_run_local_work(struct io_ring_ctx *ctx, struct io_tw_state *ts, 
	 * llists are in reverse order, flip it back the right way before

	 * running the pending items.

	 */

	node = llist_reverse_order(io_llist_xchg(&ctx->work_llist, NULL));

	node = llist_reverse_order(llist_del_all(&ctx->work_llist));

	while (node) {

		struct llist_node *next = node->next;

		struct io_kiocb *req = container_of(node, struct io_kiocb,