Commit 1e707769 authored by Kailang Yang's avatar Kailang Yang Committed by Takashi Iwai
Browse files

ALSA: hda/realtek - Set GPIO3 to default at S4 state for Thinkpad with ALC1318 



There is a chance of damaging the IC when S4 resume.
Add safe mode for no stream to disable GPIO3.
Thinkpad with ALC1318 platform need to add this workaround.

Signed-off-by: default avatarKailang Yang <kailang@realtek.com>
Link: https://lore.kernel.org/r/a853dc4f0a4e412381d5f60565181247@realtek.com


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent c158cf91

sound/pci/hda/patch_realtek.c

+50 −1
Original line number Diff line number Diff line
@@ -920,6 +920,8 @@ static void alc_pre_init(struct hda_codec *codec) 
	((codec)->core.dev.power.power_state.event == PM_EVENT_RESUME)

#define is_s4_resume(codec) \

	((codec)->core.dev.power.power_state.event == PM_EVENT_RESTORE)

#define is_s4_suspend(codec) \

	((codec)->core.dev.power.power_state.event == PM_EVENT_FREEZE)



static int alc_init(struct hda_codec *codec)

{
@@ -7183,6 +7185,44 @@ static void alc245_fixup_hp_spectre_x360_eu0xxx(struct hda_codec *codec, 
	alc245_fixup_hp_gpio_led(codec, fix, action);

}



/*

 * ALC287 PCM hooks

 */

static void alc287_alc1318_playback_pcm_hook(struct hda_pcm_stream *hinfo,

				   struct hda_codec *codec,

				   struct snd_pcm_substream *substream,

				   int action)

{

	alc_write_coef_idx(codec, 0x10, 0x8806); /* Change MLK to GPIO3 */

	switch (action) {

	case HDA_GEN_PCM_ACT_OPEN:

		alc_write_coefex_idx(codec, 0x5a, 0x00, 0x954f); /* write gpio3 to high */

		break;

	case HDA_GEN_PCM_ACT_CLOSE:

		alc_write_coefex_idx(codec, 0x5a, 0x00, 0x554f); /* write gpio3 as default value */

		break;

	}

}



static void alc287_s4_power_gpio3_default(struct hda_codec *codec)

{

	if (is_s4_suspend(codec)) {

		alc_write_coef_idx(codec, 0x10, 0x8806); /* Change MLK to GPIO3 */

		alc_write_coefex_idx(codec, 0x5a, 0x00, 0x554f); /* write gpio3 as default value */

	}

}



static void alc287_fixup_lenovo_thinkpad_with_alc1318(struct hda_codec *codec,

			       const struct hda_fixup *fix, int action)

{

	struct alc_spec *spec = codec->spec;



	if (action != HDA_FIXUP_ACT_PRE_PROBE)

		return;

	spec->power_hook = alc287_s4_power_gpio3_default;

	spec->gen.pcm_playback_hook = alc287_alc1318_playback_pcm_hook;

}





enum {

	ALC269_FIXUP_GPIO2,
@@ -7470,7 +7510,8 @@ enum { 
	ALC285_FIXUP_ASUS_GA403U_HEADSET_MIC,

	ALC285_FIXUP_ASUS_GA403U_I2C_SPEAKER2_TO_DAC1,

	ALC285_FIXUP_ASUS_GU605_SPI_2_HEADSET_MIC,

	ALC285_FIXUP_ASUS_GU605_SPI_SPEAKER2_TO_DAC1

	ALC285_FIXUP_ASUS_GU605_SPI_SPEAKER2_TO_DAC1,

	ALC287_FIXUP_LENOVO_THKPAD_WH_ALC1318,

};



/* A special fixup for Lenovo C940 and Yoga Duet 7;
@@ -9726,6 +9767,12 @@ static const struct hda_fixup alc269_fixups[] = { 
		.chained = true,

		.chain_id = ALC285_FIXUP_ASUS_GA403U,

	},

	[ALC287_FIXUP_LENOVO_THKPAD_WH_ALC1318] = {

		.type = HDA_FIXUP_FUNC,

		.v.func = alc287_fixup_lenovo_thinkpad_with_alc1318,

		.chained = true,

		.chain_id = ALC269_FIXUP_THINKPAD_ACPI

	},

};



static const struct snd_pci_quirk alc269_fixup_tbl[] = {
@@ -10394,6 +10441,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { 
	SND_PCI_QUIRK(0x17aa, 0x2318, "Thinkpad Z13 Gen2", ALC287_FIXUP_MG_RTKC_CSAMP_CS35L41_I2C_THINKPAD),

	SND_PCI_QUIRK(0x17aa, 0x2319, "Thinkpad Z16 Gen2", ALC287_FIXUP_MG_RTKC_CSAMP_CS35L41_I2C_THINKPAD),

	SND_PCI_QUIRK(0x17aa, 0x231a, "Thinkpad Z16 Gen2", ALC287_FIXUP_MG_RTKC_CSAMP_CS35L41_I2C_THINKPAD),

	SND_PCI_QUIRK(0x17aa, 0x231e, "Thinkpad", ALC287_FIXUP_LENOVO_THKPAD_WH_ALC1318),

	SND_PCI_QUIRK(0x17aa, 0x231f, "Thinkpad", ALC287_FIXUP_LENOVO_THKPAD_WH_ALC1318),

	SND_PCI_QUIRK(0x17aa, 0x30bb, "ThinkCentre AIO", ALC233_FIXUP_LENOVO_LINE2_MIC_HOTKEY),

	SND_PCI_QUIRK(0x17aa, 0x30e2, "ThinkCentre AIO", ALC233_FIXUP_LENOVO_LINE2_MIC_HOTKEY),

	SND_PCI_QUIRK(0x17aa, 0x310c, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),