Commit 1e8b7062 authored by Sunil Khatri's avatar Sunil Khatri Committed by Alex Deucher
Browse files

drm/amdgpu/userq: unmap_helper dont return the queue state 



We check for return value of amdgpu_userq_unmap_helper and
compare it against the queue->state which is logically
wrong and we should just check for failure and do the needfull.

Signed-off-by: default avatarSunil Khatri <sunil.khatri@amd.com>
Reviewed-by: default avatarChristian König <christian.koenig@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 810df8de

drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c

+1 −1
Original line number Diff line number Diff line
@@ -645,7 +645,7 @@ amdgpu_userq_destroy(struct amdgpu_userq_mgr *uq_mgr, struct amdgpu_usermode_que 
	amdgpu_userq_detect_and_reset_queues(uq_mgr);

	r = amdgpu_userq_unmap_helper(queue);

	/*TODO: It requires a reset for userq hw unmap error*/

	if (unlikely(r != AMDGPU_USERQ_STATE_UNMAPPED)) {

	if (r) {

		drm_warn(adev_to_drm(uq_mgr->adev), "trying to destroy a HW mapping userq\n");

		queue->state = AMDGPU_USERQ_STATE_HUNG;

	}