Unverified Commit 1e9974c7 authored by Maxime Ripard's avatar Maxime Ripard
Browse files

drm/vc4: hdmi: Create destroy state implementation 



Even though we were rolling our own custom state for the vc4 HDMI
controller driver, we were still using the generic helper to destroy
that state.

It was mostly working since the underlying state is the first member of
our state so the pointers are probably equal in all relevant cases, but
it's still fragile so let's fix this properly.

Reviewed-by: default avatarDave Stevenson <dave.stevenson@raspberrypi.com>
Signed-off-by: default avatarMaxime Ripard <mripard@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20231207-kms-hdmi-connector-state-v5-18-6538e19d634d@kernel.org
parent 1faed97a

drivers/gpu/drm/vc4/vc4_hdmi.c

+11 −1
Original line number Diff line number Diff line
@@ -672,11 +672,21 @@ vc4_hdmi_connector_duplicate_state(struct drm_connector *connector) 
	return &new_state->base;

}



static void vc4_hdmi_connector_destroy_state(struct drm_connector *connector,

					     struct drm_connector_state *state)

{

	struct vc4_hdmi_connector_state *vc4_state =

		conn_state_to_vc4_hdmi_conn_state(state);



	__drm_atomic_helper_connector_destroy_state(state);

	kfree(vc4_state);

}



static const struct drm_connector_funcs vc4_hdmi_connector_funcs = {

	.fill_modes = drm_helper_probe_single_connector_modes,

	.reset = vc4_hdmi_connector_reset,

	.atomic_duplicate_state = vc4_hdmi_connector_duplicate_state,

	.atomic_destroy_state = drm_atomic_helper_connector_destroy_state,

	.atomic_destroy_state = vc4_hdmi_connector_destroy_state,

	.atomic_get_property = vc4_hdmi_connector_get_property,

	.atomic_set_property = vc4_hdmi_connector_set_property,

};