Unverified Commit 1e9a9be2 authored by Christian Brauner's avatar Christian Brauner
Browse files

nsfs: use inode_just_drop() 

Currently nsfs uses the default inode_generic_drop() fallback which
drops the inode when it's unlinked or when it's unhashed. Since nsfs
never hashes inodes that always amounts to dropping the inode.

But that's just annoying to have to reason through every time we look at
this code. Switch to inode_just_drop() which always drops the inode
explicitly. This also aligns the behavior with pidfs which does the
same.

Link: https://patch.msgid.link/20251029-work-namespace-nstree-listns-v4-2-2e6f823ebdc0@kernel.org


Tested-by: default avatar <syzbot@syzkaller.appspotmail.com>
Reviewed-by: default avatarJeff Layton <jlayton@kernel.org>
Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent c9822fad

fs/nsfs.c

+1 −0
Original line number Diff line number Diff line
@@ -408,6 +408,7 @@ static const struct super_operations nsfs_ops = { 
	.statfs = simple_statfs,

	.evict_inode = nsfs_evict,

	.show_path = nsfs_show_path,

	.drop_inode = inode_just_drop,

};



static int nsfs_init_inode(struct inode *inode, void *data)