Commit 1ea74a56 authored by Andy Shevchenko's avatar Andy Shevchenko
Browse files

platform/x86: pmc_atom: introduce DEFINE_SHOW_ATTRIBUTE() macro 



This macro deduplicates a lot of similar code in the pmc_atom.c module.
Targeting to be moved to seq_file.h eventually.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
parent f1905b98

drivers/platform/x86/pmc_atom.c

+20 −36
Original line number Diff line number Diff line
@@ -208,6 +208,20 @@ static const struct pmc_data cht_data = { 
	.clks = cht_clks,

};



#define DEFINE_SHOW_ATTRIBUTE(__name)					\

static int __name ## _open(struct inode *inode, struct file *file)	\

{									\

	return single_open(file, __name ## _show, inode->i_private);	\

}									\

									\

static const struct file_operations __name ## _fops = {			\

	.owner		= THIS_MODULE,					\

	.open		= __name ## _open,				\

	.read		= seq_read,					\

	.llseek		= seq_lseek,					\

	.release	= single_release,				\

}



static inline u32 pmc_reg_read(struct pmc_dev *pmc, int reg_offset)

{

	return readl(pmc->regmap + reg_offset);
@@ -309,17 +323,7 @@ static int pmc_dev_state_show(struct seq_file *s, void *unused) 
	return 0;

}



static int pmc_dev_state_open(struct inode *inode, struct file *file)

{

	return single_open(file, pmc_dev_state_show, inode->i_private);

}



static const struct file_operations pmc_dev_state_ops = {

	.open		= pmc_dev_state_open,

	.read		= seq_read,

	.llseek		= seq_lseek,

	.release	= single_release,

};

DEFINE_SHOW_ATTRIBUTE(pmc_dev_state);



static int pmc_pss_state_show(struct seq_file *s, void *unused)

{
@@ -336,17 +340,7 @@ static int pmc_pss_state_show(struct seq_file *s, void *unused) 
	return 0;

}



static int pmc_pss_state_open(struct inode *inode, struct file *file)

{

	return single_open(file, pmc_pss_state_show, inode->i_private);

}



static const struct file_operations pmc_pss_state_ops = {

	.open		= pmc_pss_state_open,

	.read		= seq_read,

	.llseek		= seq_lseek,

	.release	= single_release,

};

DEFINE_SHOW_ATTRIBUTE(pmc_pss_state);



static int pmc_sleep_tmr_show(struct seq_file *s, void *unused)

{
@@ -367,17 +361,7 @@ static int pmc_sleep_tmr_show(struct seq_file *s, void *unused) 
	return 0;

}



static int pmc_sleep_tmr_open(struct inode *inode, struct file *file)

{

	return single_open(file, pmc_sleep_tmr_show, inode->i_private);

}



static const struct file_operations pmc_sleep_tmr_ops = {

	.open		= pmc_sleep_tmr_open,

	.read		= seq_read,

	.llseek		= seq_lseek,

	.release	= single_release,

};

DEFINE_SHOW_ATTRIBUTE(pmc_sleep_tmr);



static void pmc_dbgfs_unregister(struct pmc_dev *pmc)

{
@@ -395,17 +379,17 @@ static int pmc_dbgfs_register(struct pmc_dev *pmc) 
	pmc->dbgfs_dir = dir;



	f = debugfs_create_file("dev_state", S_IFREG | S_IRUGO,

				dir, pmc, &pmc_dev_state_ops);

				dir, pmc, &pmc_dev_state_fops);

	if (!f)

		goto err;



	f = debugfs_create_file("pss_state", S_IFREG | S_IRUGO,

				dir, pmc, &pmc_pss_state_ops);

				dir, pmc, &pmc_pss_state_fops);

	if (!f)

		goto err;



	f = debugfs_create_file("sleep_state", S_IFREG | S_IRUGO,

				dir, pmc, &pmc_sleep_tmr_ops);

				dir, pmc, &pmc_sleep_tmr_fops);

	if (!f)

		goto err;