Commit 1eae113d authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Miquel Raynal
Browse files

mtd: rawnand: nuvoton: Fix an error handling path in ma35_nand_chips_init() 



If a ma35_nand_chip_init() call fails, then a reference to 'nand_np' still
needs to be released.

Use for_each_child_of_node_scoped() to fix the issue.

Fixes: 5abb5d41 ("mtd: rawnand: nuvoton: add new driver for the Nuvoton MA35 SoC")
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
parent f544bf03

drivers/mtd/nand/raw/nuvoton-ma35d1-nand-controller.c

+2 −2
Original line number Diff line number Diff line
@@ -935,10 +935,10 @@ static void ma35_chips_cleanup(struct ma35_nand_info *nand) 


static int ma35_nand_chips_init(struct device *dev, struct ma35_nand_info *nand)

{

	struct device_node *np = dev->of_node, *nand_np;

	struct device_node *np = dev->of_node;

	int ret;



	for_each_child_of_node(np, nand_np) {

	for_each_child_of_node_scoped(np, nand_np) {

		ret = ma35_nand_chip_init(dev, nand, nand_np);

		if (ret) {

			ma35_chips_cleanup(nand);