Commit 1eb3d924 authored by Yang Jihong's avatar Yang Jihong Committed by Namhyung Kim
Browse files

perf thread_map: Free strlist on normal path in thread_map__new_by_tid_str() 



slist needs to be freed in both error path and normal path in
thread_map__new_by_tid_str().

Fixes: b52956c9 ("perf tools: Allow multiple threads or processes in record, stat, top")
Reviewed-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: default avatarYang Jihong <yangjihong1@huawei.com>
Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
Link: https://lore.kernel.org/r/20240206083228.172607-6-yangjihong1@huawei.com
parent bd2cdf26

tools/perf/util/thread_map.c

+1 −1
Original line number Diff line number Diff line
@@ -280,13 +280,13 @@ struct perf_thread_map *thread_map__new_by_tid_str(const char *tid_str) 
		threads->nr = ntasks;

	}

out:

	strlist__delete(slist);

	if (threads)

		refcount_set(&threads->refcnt, 1);

	return threads;



out_free_threads:

	zfree(&threads);

	strlist__delete(slist);

	goto out;

}