Commit 1ebcb25a authored by Kuniyuki Iwashima's avatar Kuniyuki Iwashima Committed by David S. Miller
Browse files

icmp: Fix a data-race around sysctl_icmp_ratemask. 



While reading sysctl_icmp_ratemask, it can be changed concurrently.
Thus, we need to add READ_ONCE() to its reader.

Fixes: 1da177e4 ("Linux-2.6.12-rc2")
Signed-off-by: default avatarKuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2a4eb714

net/ipv4/icmp.c

+1 −1
Original line number Diff line number Diff line
@@ -282,7 +282,7 @@ static bool icmpv4_mask_allow(struct net *net, int type, int code) 
		return true;



	/* Limit if icmp type is enabled in ratemask. */

	if (!((1 << type) & net->ipv4.sysctl_icmp_ratemask))

	if (!((1 << type) & READ_ONCE(net->ipv4.sysctl_icmp_ratemask)))

		return true;



	return false;