Commit 1ee45310 authored by Damien Le Moal's avatar Damien Le Moal Committed by Keith Busch
Browse files

nvmet: Introduce nvmet_get_cmd_effects_admin() 



In order to have a logically better organized implementation of the
effects log page, split out reporting the supported admin commands from
nvmet_get_cmd_effects_nvm() into the new function
nvmet_get_cmd_effects_admin().

Signed-off-by: default avatarDamien Le Moal <dlemoal@kernel.org>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Tested-by: default avatarRick Wertenbroek <rick.wertenbroek@gmail.com>
Tested-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: default avatarKeith Busch <kbusch@kernel.org>
parent 15e9d264

drivers/nvme/target/admin-cmd.c

+6 −1
Original line number Diff line number Diff line
@@ -230,7 +230,7 @@ static void nvmet_execute_get_log_page_smart(struct nvmet_req *req) 
	nvmet_req_complete(req, status);

}



static void nvmet_get_cmd_effects_nvm(struct nvme_effects_log *log)

static void nvmet_get_cmd_effects_admin(struct nvme_effects_log *log)

{

	log->acs[nvme_admin_get_log_page] =

	log->acs[nvme_admin_identify] =
@@ -240,7 +240,10 @@ static void nvmet_get_cmd_effects_nvm(struct nvme_effects_log *log) 
	log->acs[nvme_admin_async_event] =

	log->acs[nvme_admin_keep_alive] =

		cpu_to_le32(NVME_CMD_EFFECTS_CSUPP);

}



static void nvmet_get_cmd_effects_nvm(struct nvme_effects_log *log)

{

	log->iocs[nvme_cmd_read] =

	log->iocs[nvme_cmd_flush] =

	log->iocs[nvme_cmd_dsm]	=
@@ -276,6 +279,7 @@ static void nvmet_execute_get_log_cmd_effects_ns(struct nvmet_req *req) 


	switch (req->cmd->get_log_page.csi) {

	case NVME_CSI_NVM:

		nvmet_get_cmd_effects_admin(log);

		nvmet_get_cmd_effects_nvm(log);

		break;

	case NVME_CSI_ZNS:
@@ -283,6 +287,7 @@ static void nvmet_execute_get_log_cmd_effects_ns(struct nvmet_req *req) 
			status = NVME_SC_INVALID_IO_CMD_SET;

			goto free;

		}

		nvmet_get_cmd_effects_admin(log);

		nvmet_get_cmd_effects_nvm(log);

		nvmet_get_cmd_effects_zns(log);

		break;