Commit 1eeb5043 authored by Eric Dumazet's avatar Eric Dumazet Committed by Jakub Kicinski
Browse files

tcp/dccp: do not care about families in inet_twsk_purge() 



We lost ability to unload ipv6 module a long time ago.

Instead of calling expensive inet_twsk_purge() twice,
we can handle all families in one round.

Also remove an extra line added in my prior patch,
per Kuniyuki Iwashima feedback.

Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Link: https://lore.kernel.org/netdev/20240327192934.6843-1-kuniyu@amazon.com/


Reviewed-by: default avatarKuniyuki Iwashima <kuniyu@amazon.com>
Link: https://lore.kernel.org/r/20240329153203.345203-1-edumazet@google.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 58169ec9

include/net/inet_timewait_sock.h

+1 −1
Original line number Diff line number Diff line
@@ -111,7 +111,7 @@ static inline void inet_twsk_reschedule(struct inet_timewait_sock *tw, int timeo 


void inet_twsk_deschedule_put(struct inet_timewait_sock *tw);



void inet_twsk_purge(struct inet_hashinfo *hashinfo, int family);

void inet_twsk_purge(struct inet_hashinfo *hashinfo);



static inline

struct net *twsk_net(const struct inet_timewait_sock *twsk)

include/net/tcp.h

+1 −1
Original line number Diff line number Diff line
@@ -353,7 +353,7 @@ void tcp_rcv_established(struct sock *sk, struct sk_buff *skb); 
void tcp_rcv_space_adjust(struct sock *sk);

int tcp_twsk_unique(struct sock *sk, struct sock *sktw, void *twp);

void tcp_twsk_destructor(struct sock *sk);

void tcp_twsk_purge(struct list_head *net_exit_list, int family);

void tcp_twsk_purge(struct list_head *net_exit_list);

ssize_t tcp_splice_read(struct socket *sk, loff_t *ppos,

			struct pipe_inode_info *pipe, size_t len,

			unsigned int flags);

net/dccp/ipv4.c

+1 −1
Original line number Diff line number Diff line
@@ -1039,7 +1039,7 @@ static void __net_exit dccp_v4_exit_net(struct net *net) 


static void __net_exit dccp_v4_exit_batch(struct list_head *net_exit_list)

{

	inet_twsk_purge(&dccp_hashinfo, AF_INET);

	inet_twsk_purge(&dccp_hashinfo);

}



static struct pernet_operations dccp_v4_ops = {

net/dccp/ipv6.c

+0 −6
Original line number Diff line number Diff line
@@ -1119,15 +1119,9 @@ static void __net_exit dccp_v6_exit_net(struct net *net) 
	inet_ctl_sock_destroy(pn->v6_ctl_sk);

}



static void __net_exit dccp_v6_exit_batch(struct list_head *net_exit_list)

{

	inet_twsk_purge(&dccp_hashinfo, AF_INET6);

}



static struct pernet_operations dccp_v6_ops = {

	.init   = dccp_v6_init_net,

	.exit   = dccp_v6_exit_net,

	.exit_batch = dccp_v6_exit_batch,

	.id	= &dccp_v6_pernet_id,

	.size   = sizeof(struct dccp_v6_pernet),

};

net/ipv4/inet_timewait_sock.c

+3 −6
Original line number Diff line number Diff line
@@ -264,7 +264,7 @@ void __inet_twsk_schedule(struct inet_timewait_sock *tw, int timeo, bool rearm) 
EXPORT_SYMBOL_GPL(__inet_twsk_schedule);



/* Remove all non full sockets (TIME_WAIT and NEW_SYN_RECV) for dead netns */

void inet_twsk_purge(struct inet_hashinfo *hashinfo, int family)

void inet_twsk_purge(struct inet_hashinfo *hashinfo)

{

	struct inet_ehash_bucket *head = &hashinfo->ehash[0];

	unsigned int ehash_mask = hashinfo->ehash_mask;
@@ -273,7 +273,6 @@ void inet_twsk_purge(struct inet_hashinfo *hashinfo, int family) 
	struct sock *sk;



	for (slot = 0; slot <= ehash_mask; slot++, head++) {



		if (hlist_nulls_empty(&head->chain))

			continue;
@@ -288,15 +287,13 @@ void inet_twsk_purge(struct inet_hashinfo *hashinfo, int family) 
					     TCPF_NEW_SYN_RECV))

				continue;



			if (sk->sk_family != family ||

			    refcount_read(&sock_net(sk)->ns.count))

			if (refcount_read(&sock_net(sk)->ns.count))

				continue;



			if (unlikely(!refcount_inc_not_zero(&sk->sk_refcnt)))

				continue;



			if (unlikely(sk->sk_family != family ||

				     refcount_read(&sock_net(sk)->ns.count))) {

			if (refcount_read(&sock_net(sk)->ns.count)) {

				sock_gen_put(sk);

				goto restart;

			}