Commit 1f39e1d9 authored by Jinjie Ruan's avatar Jinjie Ruan Committed by Felix Fietkau
Browse files

wifi: mt76: Drop unnecessary error check for debugfs_create_dir() 



debugfs_create_dir() returns ERR_PTR and never return NULL.

As Russell suggested, this patch removes the error checking for
debugfs_create_dir(). This is because the DebugFS kernel API is developed
in a way that the caller can safely ignore the errors that occur during
the creation of DebugFS nodes. The debugfs APIs have a IS_ERR() judge in
start_creating() which can handle it gracefully. So these checks are
unnecessary.

Fixes: 17f1de56 ("mt76: add common code shared between multiple chipsets")
Signed-off-by: default avatarJinjie Ruan <ruanjinjie@huawei.com>
Suggested-by: default avatarRussell King (Oracle) <linux@armlinux.org.uk>
Signed-off-by: default avatarFelix Fietkau <nbd@nbd.name>
parent ced1a0b8

drivers/net/wireless/mediatek/mt76/debugfs.c

+0 −2
Original line number Diff line number Diff line
@@ -109,8 +109,6 @@ mt76_register_debugfs_fops(struct mt76_phy *phy, 
	struct dentry *dir;



	dir = debugfs_create_dir("mt76", phy->hw->wiphy->debugfsdir);

	if (!dir)

		return NULL;



	debugfs_create_u8("led_pin", 0600, dir, &phy->leds.pin);

	debugfs_create_u32("regidx", 0600, dir, &dev->debugfs_reg);