Commit 1f53d88c authored by Leon Romanovsky's avatar Leon Romanovsky
Browse files

RDMA/mlx4: Avoid false error about access to uninitialized gids array 

Smatch generates the following false error report:
drivers/infiniband/hw/mlx4/main.c:393 mlx4_ib_del_gid() error: uninitialized symbol 'gids'.

Traditionally, we are not changing kernel code and asking people to fix
the tools. However in this case, the fix can be done by simply rearranging
the code to be more clear.

Fixes: e26be1bf ("IB/mlx4: Implement ib_device callbacks")
Link: https://patch.msgid.link/6a3a1577463da16962463fcf62883a87506e9b62.1733233426.git.leonro@nvidia.com


Signed-off-by: default avatarLeon Romanovsky <leonro@nvidia.com>
parent 40384c84

drivers/infiniband/hw/mlx4/main.c

+4 −4
Original line number Diff line number Diff line
@@ -351,7 +351,7 @@ static int mlx4_ib_del_gid(const struct ib_gid_attr *attr, void **context) 
	struct mlx4_port_gid_table   *port_gid_table;

	int ret = 0;

	int hw_update = 0;

	struct gid_entry *gids;

	struct gid_entry *gids = NULL;



	if (!rdma_cap_roce_gid_table(attr->device, attr->port_num))

		return -EINVAL;
@@ -389,10 +389,10 @@ static int mlx4_ib_del_gid(const struct ib_gid_attr *attr, void **context) 
	}

	spin_unlock_bh(&iboe->lock);



	if (!ret && hw_update) {

	if (gids)

		ret = mlx4_ib_update_gids(gids, ibdev, attr->port_num);



	kfree(gids);

	}

	return ret;

}