Commit 1f5e7518 authored by Luiz Sampaio's avatar Luiz Sampaio Committed by Greg Kroah-Hartman
Browse files

w1: ds2438: fixing bug that would always get page0 



The purpose of the w1_ds2438_get_page function is to get the register
values at the page passed as the pageno parameter. However, the page0 was
hardcoded, such that the function always returned the page0 contents. Fixed
so that the function can retrieve any page.

Signed-off-by: default avatarLuiz Sampaio <sampaio.ime@gmail.com>
Link: https://lore.kernel.org/r/20210519223046.13798-5-sampaio.ime@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 67c69642

drivers/w1/slaves/w1_ds2438.c

+2 −2
Original line number Diff line number Diff line
@@ -62,13 +62,13 @@ static int w1_ds2438_get_page(struct w1_slave *sl, int pageno, u8 *buf) 
		if (w1_reset_select_slave(sl))

			continue;

		w1_buf[0] = W1_DS2438_RECALL_MEMORY;

		w1_buf[1] = 0x00;

		w1_buf[1] = (u8)pageno;

		w1_write_block(sl->master, w1_buf, 2);



		if (w1_reset_select_slave(sl))

			continue;

		w1_buf[0] = W1_DS2438_READ_SCRATCH;

		w1_buf[1] = 0x00;

		w1_buf[1] = (u8)pageno;

		w1_write_block(sl->master, w1_buf, 2);



		count = w1_read_block(sl->master, buf, DS2438_PAGE_SIZE + 1);