Commit 1fa00a56 authored by Pintu Kumar's avatar Pintu Kumar Committed by Andrew Morton
Browse files

mm/cma: fix useless return in void function 

There is a unnecessary return statement at the end of void function
cma_activate_area.  This can be dropped.

While at it, also fix another warning related to unsigned.
These are reported by checkpatch as well.

WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
+unsigned cma_area_count;

WARNING: void function return statements are not generally useful
+       return;
+}

Link: https://lkml.kernel.org/r/20240927181637.19941-1-quic_pintu@quicinc.com


Signed-off-by: default avatarPintu Kumar <quic_pintu@quicinc.com>
Cc: Pintu Agarwal <pintu.ping@gmail.com>
Cc: Shuah Khan <shuah@kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent d3db2c04

mm/cma.c

+1 −2
Original line number Diff line number Diff line
@@ -32,7 +32,7 @@ 
#include "cma.h"



struct cma cma_areas[MAX_CMA_AREAS];

unsigned cma_area_count;

unsigned int cma_area_count;

static DEFINE_MUTEX(cma_mutex);



phys_addr_t cma_get_base(const struct cma *cma)
@@ -135,7 +135,6 @@ static void __init cma_activate_area(struct cma *cma) 
	totalcma_pages -= cma->count;

	cma->count = 0;

	pr_err("CMA area %s could not be activated\n", cma->name);

	return;

}



static int __init cma_init_reserved_areas(void)