Commit 203817de authored by Pavel Begunkov's avatar Pavel Begunkov Committed by Jens Axboe
Browse files

io_uring/zcrx: fix pp destruction warnings 



With multiple page pools and in some other cases we can have allocated
niovs on page pool destruction. Remove a misplaced warning checking that
all niovs are returned to zcrx on io_pp_zc_destroy(). It was reported
before but apparently got lost.

Reported-by: default avatarPedro Tammela <pctammela@mojatatu.com>
Fixes: 34a3e608 ("io_uring/zcrx: implement zerocopy receive pp memory provider")
Signed-off-by: default avatarPavel Begunkov <asml.silence@gmail.com>
Link: https://lore.kernel.org/r/b9e6d919d2964bc48ddbf8eb52fc9f5d118e9bc1.1751878185.git.asml.silence@gmail.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 6f11adcc

io_uring/zcrx.c

+0 −3
Original line number Diff line number Diff line
@@ -862,10 +862,7 @@ static int io_pp_zc_init(struct page_pool *pp) 
static void io_pp_zc_destroy(struct page_pool *pp)

{

	struct io_zcrx_ifq *ifq = io_pp_to_ifq(pp);

	struct io_zcrx_area *area = ifq->area;



	if (WARN_ON_ONCE(area->free_count != area->nia.num_niovs))

		return;

	percpu_ref_put(&ifq->ctx->refs);

}