Commit 20594cd1 authored by Kaushlendra Kumar's avatar Kaushlendra Kumar Committed by Rafael J. Wysocki
Browse files

ACPI: button: Call input_free_device() on failing input device registration 



Make acpi_button_add() call input_free_device() when
input_register_device() fails as required according to the
documentation of the latter.

Fixes: 0d51157d ("ACPI: button: Eliminate the driver notify callback")
Signed-off-by: default avatarKaushlendra Kumar <kaushlendra.kumar@intel.com>
Cc: 6.5+ <stable@vger.kernel.org> # 6.5+
[ rjw: Subject and changelog rewrite, Fixes: tag ]
Link: https://patch.msgid.link/20251006084706.971855-1-kaushlendra.kumar@intel.com


Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 211ddde0

drivers/acpi/button.c

+3 −1
Original line number Diff line number Diff line
@@ -619,8 +619,10 @@ static int acpi_button_add(struct acpi_device *device) 


	input_set_drvdata(input, device);

	error = input_register_device(input);

	if (error)

	if (error) {

		input_free_device(input);

		goto err_remove_fs;

	}



	switch (device->device_type) {

	case ACPI_BUS_TYPE_POWER_BUTTON: