Commit 2081a845 authored by Dongli Zhang's avatar Dongli Zhang Committed by Sean Christopherson
Browse files

KVM: x86: remove always-false condition in kvmclock_sync_fn 

The 'kvmclock_periodic_sync' is a readonly param that cannot change after
bootup.

The kvm_arch_vcpu_postcreate() is not going to schedule the
kvmclock_sync_work if kvmclock_periodic_sync == false.

As a result, the "if (!kvmclock_periodic_sync)" can never be true if the
kvmclock_sync_work = kvmclock_sync_fn() is scheduled.

Link: https://lore.kernel.org/kvm/a461bf3f-c17e-9c3f-56aa-726225e8391d@oracle.com


Signed-off-by: default avatarDongli Zhang <dongli.zhang@oracle.com>
Link: https://lore.kernel.org/r/20231001213637.76686-1-dongli.zhang@oracle.com


Signed-off-by: default avatarSean Christopherson <seanjc@google.com>
parent d6800af5

arch/x86/kvm/x86.c

+0 −3
Original line number Diff line number Diff line
@@ -3374,9 +3374,6 @@ static void kvmclock_sync_fn(struct work_struct *work) 
					   kvmclock_sync_work);

	struct kvm *kvm = container_of(ka, struct kvm, arch);



	if (!kvmclock_periodic_sync)

		return;



	schedule_delayed_work(&kvm->arch.kvmclock_update_work, 0);

	schedule_delayed_work(&kvm->arch.kvmclock_sync_work,

					KVMCLOCK_SYNC_PERIOD);