Commit 208ba505 authored by yunshui's avatar yunshui Committed by Hans de Goede
Browse files

platform/x86: msi-laptop: Use sysfs_emit() to replace sprintf() 



As Documentation/filesystems/sysfs.rst suggested,
show() should only use sysfs_emit() or sysfs_emit_at() when formatting
the value to be returned to user space.

Signed-off-by: default avataryunshui <jiangyunshui@kylinos.cn>
Reviewed-by: default avatarAi Chao <aichao@kylinos.cn>
Link: https://lore.kernel.org/r/20240419063649.2396461-1-jiangyunshui@kylinos.cn


Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent 95cd8806

drivers/platform/x86/msi-laptop.c

+10 −10
Original line number Diff line number Diff line
@@ -317,7 +317,7 @@ static ssize_t show_wlan(struct device *dev, 
	if (ret < 0)

		return ret;



	return sprintf(buf, "%i\n", enabled);

	return sysfs_emit(buf, "%i\n", enabled);

}



static ssize_t store_wlan(struct device *dev,
@@ -341,7 +341,7 @@ static ssize_t show_bluetooth(struct device *dev, 
	if (ret < 0)

		return ret;



	return sprintf(buf, "%i\n", enabled);

	return sysfs_emit(buf, "%i\n", enabled);

}



static ssize_t store_bluetooth(struct device *dev,
@@ -364,7 +364,7 @@ static ssize_t show_threeg(struct device *dev, 
	if (ret < 0)

		return ret;



	return sprintf(buf, "%i\n", threeg_s);

	return sysfs_emit(buf, "%i\n", threeg_s);

}



static ssize_t store_threeg(struct device *dev,
@@ -383,7 +383,7 @@ static ssize_t show_lcd_level(struct device *dev, 
	if (ret < 0)

		return ret;



	return sprintf(buf, "%i\n", ret);

	return sysfs_emit(buf, "%i\n", ret);

}



static ssize_t store_lcd_level(struct device *dev,
@@ -413,7 +413,7 @@ static ssize_t show_auto_brightness(struct device *dev, 
	if (ret < 0)

		return ret;



	return sprintf(buf, "%i\n", ret);

	return sysfs_emit(buf, "%i\n", ret);

}



static ssize_t store_auto_brightness(struct device *dev,
@@ -443,7 +443,7 @@ static ssize_t show_touchpad(struct device *dev, 
	if (result < 0)

		return result;



	return sprintf(buf, "%i\n", !!(rdata & MSI_STANDARD_EC_TOUCHPAD_MASK));

	return sysfs_emit(buf, "%i\n", !!(rdata & MSI_STANDARD_EC_TOUCHPAD_MASK));

}



static ssize_t show_turbo(struct device *dev,
@@ -457,7 +457,7 @@ static ssize_t show_turbo(struct device *dev, 
	if (result < 0)

		return result;



	return sprintf(buf, "%i\n", !!(rdata & MSI_STANDARD_EC_TURBO_MASK));

	return sysfs_emit(buf, "%i\n", !!(rdata & MSI_STANDARD_EC_TURBO_MASK));

}



static ssize_t show_eco(struct device *dev,
@@ -471,7 +471,7 @@ static ssize_t show_eco(struct device *dev, 
	if (result < 0)

		return result;



	return sprintf(buf, "%i\n", !!(rdata & MSI_STANDARD_EC_ECO_MASK));

	return sysfs_emit(buf, "%i\n", !!(rdata & MSI_STANDARD_EC_ECO_MASK));

}



static ssize_t show_turbo_cooldown(struct device *dev,
@@ -485,7 +485,7 @@ static ssize_t show_turbo_cooldown(struct device *dev, 
	if (result < 0)

		return result;



	return sprintf(buf, "%i\n", (!!(rdata & MSI_STANDARD_EC_TURBO_MASK)) |

	return sysfs_emit(buf, "%i\n", (!!(rdata & MSI_STANDARD_EC_TURBO_MASK)) |

		(!!(rdata & MSI_STANDARD_EC_TURBO_COOLDOWN_MASK) << 1));

}
@@ -500,7 +500,7 @@ static ssize_t show_auto_fan(struct device *dev, 
	if (result < 0)

		return result;



	return sprintf(buf, "%i\n", !!(rdata & MSI_STANDARD_EC_AUTOFAN_MASK));

	return sysfs_emit(buf, "%i\n", !!(rdata & MSI_STANDARD_EC_AUTOFAN_MASK));

}



static ssize_t store_auto_fan(struct device *dev,