Commit 20b93a00 authored by Artem Shimko's avatar Artem Shimko Committed by Sudeep Holla
Browse files

firmware: arm_scmi: Fix premature SCMI_XFER_FLAG_IS_RAW clearing in raw mode 



The SCMI_XFER_FLAG_IS_RAW flag was being cleared prematurely in
scmi_xfer_raw_put() before the transfer completion was properly
acknowledged by the raw message handlers.

Move the clearing of SCMI_XFER_FLAG_IS_RAW and SCMI_XFER_FLAG_CHAN_SET
from scmi_xfer_raw_put() to __scmi_xfer_put() to ensure the flags remain
set throughout the entire raw message processing pipeline until the
transfer is returned to the free pool.

Fixes: 3095a3e2 ("firmware: arm_scmi: Add xfer helpers to provide raw access")
Suggested-by: default avatarCristian Marussi <cristian.marussi@arm.com>
Signed-off-by: default avatarArtem Shimko <a.shimko.dev@gmail.com>
Reviewed-by: default avatarCristian Marussi <cristian.marussi@arm.com>
Message-Id: <20251008091057.1969260-1-a.shimko.dev@gmail.com>
Signed-off-by: default avatarSudeep Holla <sudeep.holla@arm.com>
parent 092b9e2c

drivers/firmware/arm_scmi/driver.c

+1 −2
Original line number Diff line number Diff line
@@ -805,6 +805,7 @@ __scmi_xfer_put(struct scmi_xfers_info *minfo, struct scmi_xfer *xfer) 


			scmi_dec_count(info->dbg, XFERS_INFLIGHT);

		}

		xfer->flags = 0;

		hlist_add_head(&xfer->node, &minfo->free_xfers);

	}

	spin_unlock_irqrestore(&minfo->xfer_lock, flags);
@@ -823,8 +824,6 @@ void scmi_xfer_raw_put(const struct scmi_handle *handle, struct scmi_xfer *xfer) 
{

	struct scmi_info *info = handle_to_scmi_info(handle);



	xfer->flags &= ~SCMI_XFER_FLAG_IS_RAW;

	xfer->flags &= ~SCMI_XFER_FLAG_CHAN_SET;

	return __scmi_xfer_put(&info->tx_minfo, xfer);

}