Commit 20cbe460 authored by Filipe Manana's avatar Filipe Manana Committed by David Sterba
Browse files

btrfs: use btrfs_crit at btrfs_mark_buffer_dirty() 



There's no need to use WARN() at btrfs_mark_buffer_dirty() to print an
error message, as we have the fs_info pointer we can use btrfs_crit()
which prints device information and makes the message have a more uniform
format. As we are already aborting the transaction we already have a stack
trace printed as well. So replace the use of WARN() with btrfs_crit().

Also slightly reword the message to use 'logical' instead of 'block' as
it's what is used in other error/warning messages.

Signed-off-by: default avatarFilipe Manana <fdmanana@suse.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 50564b65

fs/btrfs/disk-io.c

+3 −2
Original line number Diff line number Diff line
@@ -4404,9 +4404,10 @@ void btrfs_mark_buffer_dirty(struct btrfs_trans_handle *trans, 
	ASSERT(trans->transid == fs_info->generation);

	btrfs_assert_tree_write_locked(buf);

	if (transid != fs_info->generation) {

		WARN(1, KERN_CRIT "btrfs transid mismatch buffer %llu, found %llu running %llu\n",

			buf->start, transid, fs_info->generation);

		btrfs_abort_transaction(trans, -EUCLEAN);

		btrfs_crit(fs_info,

"dirty buffer transid mismatch, logical %llu found transid %llu running transid %llu",

			   buf->start, transid, fs_info->generation);

	}

	set_extent_buffer_dirty(buf);

}