Commit 20e62271 authored by Bartosz Golaszewski's avatar Bartosz Golaszewski Committed by Andy Shevchenko
Browse files

pinctrl: lynxpoint: use new GPIO line value setter callbacks 



struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Acked-by: default avatarMika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
parent 241d79f0

drivers/pinctrl/intel/pinctrl-lynxpoint.c

+4 −2
Original line number Diff line number Diff line
@@ -503,7 +503,7 @@ static int lp_gpio_get(struct gpio_chip *chip, unsigned int offset) 
	return !!(ioread32(reg) & IN_LVL_BIT);

}



static void lp_gpio_set(struct gpio_chip *chip, unsigned int offset, int value)

static int lp_gpio_set(struct gpio_chip *chip, unsigned int offset, int value)

{

	struct intel_pinctrl *lg = gpiochip_get_data(chip);

	void __iomem *reg = lp_gpio_reg(chip, offset, LP_CONFIG1);
@@ -514,6 +514,8 @@ static void lp_gpio_set(struct gpio_chip *chip, unsigned int offset, int value) 
		iowrite32(ioread32(reg) | OUT_LVL_BIT, reg);

	else

		iowrite32(ioread32(reg) & ~OUT_LVL_BIT, reg);



	return 0;

}



static int lp_gpio_direction_input(struct gpio_chip *chip, unsigned int offset)
@@ -775,7 +777,7 @@ static int lp_gpio_probe(struct platform_device *pdev) 
	gc->direction_input = lp_gpio_direction_input;

	gc->direction_output = lp_gpio_direction_output;

	gc->get = lp_gpio_get;

	gc->set = lp_gpio_set;

	gc->set_rv = lp_gpio_set;

	gc->set_config = gpiochip_generic_config;

	gc->get_direction = lp_gpio_get_direction;

	gc->base = -1;