Commit 21221206 authored by Laurentiu Mihalcea's avatar Laurentiu Mihalcea Committed by Philipp Zabel
Browse files

reset: imx8mp-audiomix: Drop unneeded macros 



The macros defining the mask values for the EARC, EARC PHY resets,
and the DSP RUN_STALL signal can be dropped as they are not and will
not be used anywhere else except to set the value of the "mask" field
from "struct imx8mp_reset_map". In this particular case, based on the
name of the "mask" field, you can already deduce what these values are
for, which is why defining macros for them doesn't offer any new
information, nor does it help with the code readability.

Reviewed-by: default avatarDaniel Baluta <daniel.baluta@nxp.com>
Reviewed-by: default avatarFrank Li <Frank.Li@nxp.com>
Reviewed-by: default avatarPhilipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: default avatarLaurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
Signed-off-by: default avatarPhilipp Zabel <p.zabel@pengutronix.de>
parent 16de4c6a

drivers/reset/reset-imx8mp-audiomix.c

+4 −7
Original line number Diff line number Diff line
@@ -6,6 +6,7 @@ 
#include <dt-bindings/reset/imx8mp-reset-audiomix.h>



#include <linux/auxiliary_bus.h>

#include <linux/bits.h>

#include <linux/device.h>

#include <linux/io.h>

#include <linux/module.h>
@@ -14,11 +15,7 @@ 
#include <linux/reset-controller.h>



#define IMX8MP_AUDIOMIX_EARC_RESET_OFFSET	0x200

#define IMX8MP_AUDIOMIX_EARC_RESET_MASK		BIT(0)

#define IMX8MP_AUDIOMIX_EARC_PHY_RESET_MASK	BIT(1)



#define IMX8MP_AUDIOMIX_DSP_RUNSTALL_OFFSET	0x108

#define IMX8MP_AUDIOMIX_DSP_RUNSTALL_MASK	BIT(5)



struct imx8mp_reset_map {

	unsigned int offset;
@@ -29,17 +26,17 @@ struct imx8mp_reset_map { 
static const struct imx8mp_reset_map reset_map[] = {

	[IMX8MP_AUDIOMIX_EARC_RESET] = {

		.offset	= IMX8MP_AUDIOMIX_EARC_RESET_OFFSET,

		.mask	= IMX8MP_AUDIOMIX_EARC_RESET_MASK,

		.mask = BIT(0),

		.active_low = true,

	},

	[IMX8MP_AUDIOMIX_EARC_PHY_RESET] = {

		.offset	= IMX8MP_AUDIOMIX_EARC_RESET_OFFSET,

		.mask	= IMX8MP_AUDIOMIX_EARC_PHY_RESET_MASK,

		.mask = BIT(1),

		.active_low = true,

	},

	[IMX8MP_AUDIOMIX_DSP_RUNSTALL] = {

		.offset	= IMX8MP_AUDIOMIX_DSP_RUNSTALL_OFFSET,

		.mask	= IMX8MP_AUDIOMIX_DSP_RUNSTALL_MASK,

		.mask = BIT(5),

		.active_low = false,

	},

};