Commit 212fe1c0 authored by Kairui Song's avatar Kairui Song Committed by Andrew Morton
Browse files

zram: fix potential UAF of zram table 

If zram_meta_alloc failed early, it frees allocated zram->table without
setting it NULL.  Which will potentially cause zram_meta_free to access
the table if user reset an failed and uninitialized device.

Link: https://lkml.kernel.org/r/20250107065446.86928-1-ryncsn@gmail.com


Fixes: 74363ec6 ("zram: fix uninitialized ZRAM not releasing backing device")
Signed-off-by: default avatarKairui Song <kasong@tencent.com>
Reviewed-by: default avatarSergey Senozhatsky <senozhatsky@chromium.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent a32bf5bb

drivers/block/zram/zram_drv.c

+1 −0
Original line number Diff line number Diff line
@@ -1468,6 +1468,7 @@ static bool zram_meta_alloc(struct zram *zram, u64 disksize) 
	zram->mem_pool = zs_create_pool(zram->disk->disk_name);

	if (!zram->mem_pool) {

		vfree(zram->table);

		zram->table = NULL;

		return false;

	}