Commit 214ae22e authored by Claudiu Beznea's avatar Claudiu Beznea Committed by Mathieu Poirier
Browse files

rpmsg: core: Drop dev_pm_domain_detach() call 



Starting with commit f9950807 ("PM: domains: Detach on
device_unbind_cleanup()"), there is no longer a need to call
dev_pm_domain_detach() in the bus remove function. The
device_unbind_cleanup() function now handles this to avoid
invoking devres cleanup handlers while the PM domain is
powered off, which could otherwise lead to failures as
described in the above-mentioned commit.

Drop the explicit dev_pm_domain_detach() call and rely instead
on the flags passed to dev_pm_domain_attach() to power off the
domain.

Signed-off-by: default avatarClaudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Reviewed-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
Link: https://lore.kernel.org/r/20250827101352.927542-1-claudiu.beznea.uj@bp.renesas.com


Signed-off-by: default avatarMathieu Poirier <mathieu.poirier@linaro.org>
parent 6e29c30d

drivers/rpmsg/rpmsg_core.c

+2 −3
Original line number Diff line number Diff line
@@ -479,7 +479,8 @@ static int rpmsg_dev_probe(struct device *dev) 
	struct rpmsg_endpoint *ept = NULL;

	int err;



	err = dev_pm_domain_attach(dev, PD_FLAG_ATTACH_POWER_ON);

	err = dev_pm_domain_attach(dev, PD_FLAG_ATTACH_POWER_ON |

					PD_FLAG_DETACH_POWER_OFF);

	if (err)

		goto out;
@@ -538,8 +539,6 @@ static void rpmsg_dev_remove(struct device *dev) 
	if (rpdrv->remove)

		rpdrv->remove(rpdev);



	dev_pm_domain_detach(dev, true);



	if (rpdev->ept)

		rpmsg_destroy_ept(rpdev->ept);

}