Commit 215c90ee authored by Bartosz Golaszewski's avatar Bartosz Golaszewski Committed by Greg Kroah-Hartman
Browse files

device property: set fwnode->secondary to NULL in fwnode_init() 



If a firmware node is allocated on the stack (for instance: temporary
software node whose life-time we control) or on the heap - but using a
non-zeroing allocation function - and initialized using fwnode_init(),
its secondary pointer will contain uninitalized memory which likely will
be neither NULL nor IS_ERR() and so may end up being dereferenced (for
example: in dev_to_swnode()). Set fwnode->secondary to NULL on
initialization.

Cc: stable <stable@kernel.org>
Fixes: 01bb86b3 ("driver core: Add fwnode_init()")
Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Reviewed-by: default avatarRafael J. Wysocki (Intel) <rafael@kernel.org>
Reviewed-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Link: https://patch.msgid.link/20260506115701.23035-1-bartosz.golaszewski@oss.qualcomm.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 237557b8

include/linux/fwnode.h

+1 −0
Original line number Diff line number Diff line
@@ -208,6 +208,7 @@ struct fwnode_operations { 
static inline void fwnode_init(struct fwnode_handle *fwnode,

			       const struct fwnode_operations *ops)

{

	fwnode->secondary = NULL;

	fwnode->ops = ops;

	INIT_LIST_HEAD(&fwnode->consumers);

	INIT_LIST_HEAD(&fwnode->suppliers);