Unverified Commit 215e5fe7 authored by Cássio Gabriel's avatar Cássio Gabriel Committed by Mark Brown
Browse files

ASoC: SOF: topology: reject invalid vendor array size in token parser 



sof_parse_token_sets() accepts array->size values that can be invalid
for a vendor tuple array header. In particular, a zero size does not
advance the parser state and can lead to non-progress parsing on
malformed topology data.

Validate array->size against the minimum header size and reject values
smaller than sizeof(*array) before parsing. This preserves behavior for
valid topologies and hardens malformed-input handling.

Signed-off-by: default avatarCássio Gabriel <cassiogabrielcontato@gmail.com>
Acked-by: default avatarPeter Ujfalusi <peter.ujfalusi@linux.intel.com>
Link: https://patch.msgid.link/20260319-sof-topology-array-size-fix-v1-1-f9191b16b1b7@gmail.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent a437601a

sound/soc/sof/topology.c

+1 −1
Original line number Diff line number Diff line
@@ -736,7 +736,7 @@ static int sof_parse_token_sets(struct snd_soc_component *scomp, 
		asize = le32_to_cpu(array->size);



		/* validate asize */

		if (asize < 0) { /* FIXME: A zero-size array makes no sense */

		if (asize < sizeof(*array)) {

			dev_err(scomp->dev, "error: invalid array size 0x%x\n",

				asize);

			return -EINVAL;