Commit 2190966f authored Nov 28, 2024 by Peter Zijlstra

x86: Convert unreachable() to BUG()



Avoid unreachable() as it can (and will in the absence of UBSAN)
generate fallthrough code. Use BUG() so we get a UD2 trap (with
unreachable annotation).

Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Josh Poimboeuf <jpoimboe@kernel.org>
Link: https://lore.kernel.org/r/20241128094312.028316261@infradead.org

parent c837de38

arch/x86/kernel/process.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -838,7 +838,7 @@ void __noreturn stop_this_cpu(void *dummy)
		#ifdef CONFIG_SMP
		if (smp_ops.stop_this_cpu) {
		smp_ops.stop_this_cpu();
		unreachable();
		BUG();
		}
		#endif

arch/x86/kernel/reboot.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -883,7 +883,7 @@ static int crash_nmi_callback(unsigned int val, struct pt_regs *regs)

		if (smp_ops.stop_this_cpu) {
		smp_ops.stop_this_cpu();
		unreachable();
		BUG();
		}

		/* Assume hlt works */

arch/x86/kvm/svm/sev.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -3820,7 +3820,7 @@ static int snp_begin_psc(struct vcpu_svm svm, struct psc_buffer psc)
		goto next_range;
		}

		unreachable();
		BUG();
		}

		static int __sev_snp_update_protected_guest_state(struct kvm_vcpu *vcpu)