Commit 21ab5179 authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Carlos Maiolino
Browse files

xfs: fix zone selection in xfs_select_open_zone_mru 



xfs_select_open_zone_mru needs to pass XFS_ZONE_ALLOC_OK to
xfs_try_use_zone because we only want to tightly pack into zones of the
same or a compatible temperature instead of any available zone.

This got broken in commit 0301dae7 ("xfs: refactor hint based zone
allocation"), which failed to update this particular caller when
switching to an enum.  xfs/638 sometimes, but not reliably fails due to
this change.

Fixes: 0301dae7 ("xfs: refactor hint based zone allocation")
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarHans Holmberg <hans.holmberg@wdc.com>
Signed-off-by: default avatarCarlos Maiolino <cem@kernel.org>
parent f5714a3c

fs/xfs/xfs_zone_alloc.c

+1 −1
Original line number Diff line number Diff line
@@ -615,7 +615,7 @@ xfs_select_open_zone_mru( 
	lockdep_assert_held(&zi->zi_open_zones_lock);



	list_for_each_entry_reverse(oz, &zi->zi_open_zones, oz_entry)

		if (xfs_try_use_zone(zi, file_hint, oz, false))

		if (xfs_try_use_zone(zi, file_hint, oz, XFS_ZONE_ALLOC_OK))

			return oz;



	cond_resched_lock(&zi->zi_open_zones_lock);