Commit 21b362cc authored by Tony Luck's avatar Tony Luck Committed by Borislav Petkov (AMD)
Browse files

x86/resctrl: Enable shared RMID mode on Sub-NUMA Cluster (SNC) systems 



Hardware has two RMID configuration options for SNC systems. The default
mode divides RMID counters between SNC nodes. E.g. with 200 RMIDs and
two SNC nodes per L3 cache RMIDs 0..99 are used on node 0, and 100..199
on node 1. This isn't compatible with Linux resctrl usage. On this
example system a process using RMID 5 would only update monitor counters
while running on SNC node 0.

The other mode is "RMID Sharing Mode". This is enabled by clearing bit
0 of the RMID_SNC_CONFIG (0xCA0) model specific register. In this mode
the number of logical RMIDs is the number of physical RMIDs (from CPUID
leaf 0xF) divided by the number of SNC nodes per L3 cache instance. A
process can use the same RMID across different SNC nodes.

See the "Intel Resource Director Technology Architecture Specification"
for additional details.

When SNC is enabled, update the MSR when a monitor domain is marked
online. Technically this is overkill. It only needs to be done once
per L3 cache instance rather than per SNC domain. But there is no harm
in doing it more than once, and this is not in a critical path.

Signed-off-by: default avatarTony Luck <tony.luck@intel.com>
Signed-off-by: default avatarBorislav Petkov (AMD) <bp@alien8.de>
Reviewed-by: default avatarReinette Chatre <reinette.chatre@intel.com>
Link: https://lore.kernel.org/r/20240702173820.90368-3-tony.luck@intel.com
parent 9fbb303e

arch/x86/include/asm/msr-index.h

+1 −0
Original line number Diff line number Diff line
@@ -1164,6 +1164,7 @@ 
#define MSR_IA32_QM_CTR			0xc8e

#define MSR_IA32_PQR_ASSOC		0xc8f

#define MSR_IA32_L3_CBM_BASE		0xc90

#define MSR_RMID_SNC_CONFIG		0xca0

#define MSR_IA32_L2_CBM_BASE		0xd10

#define MSR_IA32_MBA_THRTL_BASE		0xd50

arch/x86/kernel/cpu/resctrl/core.c

+2 −0
Original line number Diff line number Diff line
@@ -615,6 +615,8 @@ static void domain_add_cpu_mon(int cpu, struct rdt_resource *r) 
	}

	cpumask_set_cpu(cpu, &d->hdr.cpu_mask);



	arch_mon_domain_online(r, d);



	if (arch_domain_mbm_alloc(r->num_rmid, hw_dom)) {

		mon_domain_free(hw_dom);

		return;

arch/x86/kernel/cpu/resctrl/internal.h

+2 −0
Original line number Diff line number Diff line
@@ -534,6 +534,8 @@ static inline bool resctrl_arch_get_cdp_enabled(enum resctrl_res_level l) 


int resctrl_arch_set_cdp_enabled(enum resctrl_res_level l, bool enable);



void arch_mon_domain_online(struct rdt_resource *r, struct rdt_mon_domain *d);



/*

 * To return the common struct rdt_resource, which is contained in struct

 * rdt_hw_resource, walk the resctrl member of struct rdt_hw_resource.

arch/x86/kernel/cpu/resctrl/monitor.c

+20 −0
Original line number Diff line number Diff line
@@ -1090,6 +1090,26 @@ static void l3_mon_evt_init(struct rdt_resource *r) 
		list_add_tail(&mbm_local_event.list, &r->evt_list);

}



/*

 * The power-on reset value of MSR_RMID_SNC_CONFIG is 0x1

 * which indicates that RMIDs are configured in legacy mode.

 * This mode is incompatible with Linux resctrl semantics

 * as RMIDs are partitioned between SNC nodes, which requires

 * a user to know which RMID is allocated to a task.

 * Clearing bit 0 reconfigures the RMID counters for use

 * in RMID sharing mode. This mode is better for Linux.

 * The RMID space is divided between all SNC nodes with the

 * RMIDs renumbered to start from zero in each node when

 * counting operations from tasks. Code to read the counters

 * must adjust RMID counter numbers based on SNC node. See

 * logical_rmid_to_physical_rmid() for code that does this.

 */

void arch_mon_domain_online(struct rdt_resource *r, struct rdt_mon_domain *d)

{

	if (snc_nodes_per_l3_cache > 1)

		msr_clear_bit(MSR_RMID_SNC_CONFIG, 0);

}



int __init rdt_get_mon_l3_config(struct rdt_resource *r)

{

	unsigned int mbm_offset = boot_cpu_data.x86_cache_mbm_width_offset;