Commit 21c0efbc authored by Kuan-Wei Chiu's avatar Kuan-Wei Chiu Committed by Abel Vesa
Browse files

clk: imx: scu: Fix memory leak in __imx_clk_gpr_scu() 



In cases where imx_clk_is_resource_owned() returns false, the code path
does not handle the failure gracefully, potentially leading to a memory
leak. This fix ensures proper cleanup by freeing the allocated memory
for 'clk_node' before returning.

Signed-off-by: default avatarKuan-Wei Chiu <visitorckw@gmail.com>
Reviewed-by: default avatarPeng Fan <peng.fan@nxp.com>
Link: https://lore.kernel.org/all/20231210171907.3410922-1-visitorckw@gmail.com/


Signed-off-by: default avatarAbel Vesa <abel.vesa@linaro.org>
parent 144f1b70

drivers/clk/imx/clk-scu.c

+3 −1
Original line number Diff line number Diff line
@@ -886,8 +886,10 @@ struct clk_hw *__imx_clk_gpr_scu(const char *name, const char * const *parent_na 
		return ERR_PTR(-EINVAL);

	}



	if (!imx_clk_is_resource_owned(rsrc_id))

	if (!imx_clk_is_resource_owned(rsrc_id)) {

		kfree(clk_node);

		return NULL;

	}



	clk = kzalloc(sizeof(*clk), GFP_KERNEL);

	if (!clk) {