Commit 21ce931e authored by Ian Rogers's avatar Ian Rogers Committed by Namhyung Kim
Browse files

perf symbol: Avoid an undefined behavior warning 



The node (nd) may be NULL and pointer arithmetic on NULL is undefined
behavior. Move the computation of next below the NULL check on the
node.

Signed-off-by: default avatarIan Rogers <irogers@google.com>
Cc: James Clark <james.clark@arm.com>
Link: https://lore.kernel.org/r/20230914044233.1550195-1-irogers@google.com


Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
parent 999b81b9

tools/perf/util/symbol.c

+1 −2
Original line number Diff line number Diff line
@@ -202,11 +202,10 @@ void symbols__fixup_duplicate(struct rb_root_cached *symbols) 
		curr = rb_entry(nd, struct symbol, rb_node);

again:

		nd = rb_next(&curr->rb_node);

		next = rb_entry(nd, struct symbol, rb_node);



		if (!nd)

			break;



		next = rb_entry(nd, struct symbol, rb_node);

		if (curr->start != next->start)

			continue;