Commit 21d59d00 authored by Darrick J. Wong's avatar Darrick J. Wong
Browse files

xfs: remove deprecated sysctl knobs 



These sysctl knobs were scheduled for removal in September 2025.  That
time has come, so remove them.

Signed-off-by: default avatar"Darrick J. Wong" <djwong@kernel.org>
Reviewed-by: default avatarCarlos Maiolino <cmaiolino@redhat.com>
parent b9a176e5

Documentation/admin-guide/xfs.rst

+4 −22
Original line number Diff line number Diff line
@@ -289,9 +289,6 @@ The following sysctls are available for the XFS filesystem: 
	removes unused preallocation from clean inodes and releases

	the unused space back to the free pool.



  fs.xfs.speculative_cow_prealloc_lifetime

	This is an alias for speculative_prealloc_lifetime.



  fs.xfs.error_level		(Min: 0  Default: 3  Max: 11)

	A volume knob for error reporting when internal errors occur.

	This will generate detailed messages & backtraces for filesystem
@@ -318,17 +315,6 @@ The following sysctls are available for the XFS filesystem: 


	This option is intended for debugging only.



  fs.xfs.irix_symlink_mode	(Min: 0  Default: 0  Max: 1)

	Controls whether symlinks are created with mode 0777 (default)

	or whether their mode is affected by the umask (irix mode).



  fs.xfs.irix_sgid_inherit	(Min: 0  Default: 0  Max: 1)

	Controls files created in SGID directories.

	If the group ID of the new file does not match the effective group

	ID or one of the supplementary group IDs of the parent dir, the

	ISGID bit is cleared if the irix_sgid_inherit compatibility sysctl

	is set.



  fs.xfs.inherit_sync		(Min: 0  Default: 1  Max: 1)

	Setting this to "1" will cause the "sync" flag set

	by the **xfs_io(8)** chattr command on a directory to be
@@ -364,14 +350,7 @@ The following sysctls are available for the XFS filesystem: 
Deprecated Sysctls

==================



===========================================     ================

  Name                                          Removal Schedule

===========================================     ================

fs.xfs.irix_sgid_inherit                        September 2025

fs.xfs.irix_symlink_mode                        September 2025

fs.xfs.speculative_cow_prealloc_lifetime        September 2025

===========================================     ================



None currently.



Removed Sysctls

===============
@@ -381,6 +360,9 @@ Removed Sysctls 
=============================	=======

  fs.xfs.xfsbufd_centisec	v4.0

  fs.xfs.age_buffer_centisecs	v4.0

  fs.xfs.irix_symlink_mode      v6.18

  fs.xfs.irix_sgid_inherit      v6.18

  fs.xfs.speculative_cow_prealloc_lifetime      v6.18

=============================	=======



Error handling

fs/xfs/libxfs/xfs_inode_util.c

+0 −11
Original line number Diff line number Diff line
@@ -299,17 +299,6 @@ xfs_inode_init( 
		} else {

			inode_init_owner(args->idmap, inode, dir, args->mode);

		}



		/*

		 * If the group ID of the new file does not match the effective

		 * group ID or one of the supplementary group IDs, the S_ISGID

		 * bit is cleared (and only if the irix_sgid_inherit

		 * compatibility variable is set).

		 */

		if (irix_sgid_inherit && (inode->i_mode & S_ISGID) &&

		    !vfsgid_in_group_p(i_gid_into_vfsgid(args->idmap, inode)))

			inode->i_mode &= ~S_ISGID;



		ip->i_projid = xfs_get_initial_prid(pip);

	}

fs/xfs/xfs_globals.c

+0 −2
Original line number Diff line number Diff line
@@ -14,8 +14,6 @@ 
 */

xfs_param_t xfs_params = {

			  /*	MIN		DFLT		MAX	*/

	.sgid_inherit	= {	0,		0,		1	},

	.symlink_mode	= {	0,		0,		1	},

	.panic_mask	= {	0,		0,		XFS_PTAG_MASK},

	.error_level	= {	0,		3,		11	},

	.syncd_timer	= {	1*100,		30*100,		7200*100},

fs/xfs/xfs_iops.c

+5 −7
Original line number Diff line number Diff line
@@ -435,10 +435,8 @@ xfs_vn_symlink( 
	struct xfs_inode	*cip = NULL;

	struct xfs_name		name;

	int			error;

	umode_t		mode;

	umode_t			mode = S_IFLNK | S_IRWXUGO;



	mode = S_IFLNK |

		(irix_symlink_mode ? 0777 & ~current_umask() : S_IRWXUGO);

	error = xfs_dentry_mode_to_name(&name, dentry, mode);

	if (unlikely(error))

		goto out;

fs/xfs/xfs_linux.h

+0 −2
Original line number Diff line number Diff line
@@ -89,8 +89,6 @@ typedef __u32 xfs_nlink_t; 
#undef XFS_NATIVE_HOST

#endif



#define irix_sgid_inherit	xfs_params.sgid_inherit.val

#define irix_symlink_mode	xfs_params.symlink_mode.val

#define xfs_panic_mask		xfs_params.panic_mask.val

#define xfs_error_level		xfs_params.error_level.val

#define xfs_syncd_centisecs	xfs_params.syncd_timer.val