Commit 21d8525d authored by Takashi Iwai's avatar Takashi Iwai Committed by Greg Kroah-Hartman
Browse files

usb: gadget: midi2: Fix missing UMP group attributes initialization 



The gadget card driver forgot to call snd_ump_update_group_attrs()
after adding FBs, and this leaves the UMP group attributes
uninitialized.  As a result, -ENODEV error is returned at opening a
legacy rawmidi device as an inactive group.

This patch adds the missing call to address the behavior above.

Fixes: 8b645922 ("usb: gadget: Add support for USB MIDI 2.0 function driver")
Cc: stable <stable@kernel.org>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20250904153932.13589-1-tiwai@suse.de


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f34bfcc7

drivers/usb/gadget/function/f_midi2.c

+1 −0
Original line number Diff line number Diff line
@@ -1599,6 +1599,7 @@ static int f_midi2_create_card(struct f_midi2 *midi2) 
			strscpy(fb->info.name, ump_fb_name(b),

				sizeof(fb->info.name));

		}

		snd_ump_update_group_attrs(ump);

	}



	for (i = 0; i < midi2->num_eps; i++) {