Commit 21e1fe9e authored by Asbjørn Sloth Tønnesen's avatar Asbjørn Sloth Tønnesen Committed by Tony Nguyen
Browse files

ice: flower: validate control flags 



This driver currently doesn't support any control flags.

Use flow_rule_has_control_flags() to check for control flags,
such as can be set through `tc flower ... ip_flags frag`.

In case any control flags are masked, flow_rule_has_control_flags()
sets a NL extended error message, and we return -EOPNOTSUPP.

Only compile-tested.

Signed-off-by: default avatarAsbjørn Sloth Tønnesen <ast@fiberby.net>
Reviewed-by: default avatarMichal Swiatkowski <michal.swiatkowski@linux.intel.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Tested-by: default avatarSujai Buvaneswaran <sujai.buvaneswaran@intel.com>
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
parent c7b9c494

drivers/net/ethernet/intel/ice/ice_tc_lib.c

+4 −0
Original line number Diff line number Diff line
@@ -1658,6 +1658,10 @@ ice_parse_cls_flower(struct net_device *filter_dev, struct ice_vsi *vsi, 
		flow_rule_match_control(rule, &match);



		addr_type = match.key->addr_type;



		if (flow_rule_has_control_flags(match.mask->flags,

						fltr->extack))

			return -EOPNOTSUPP;

	}



	if (addr_type == FLOW_DISSECTOR_KEY_IPV4_ADDRS) {