Unverified Commit 22206e56 authored by Everest K.C's avatar Everest K.C Committed by Mark Brown
Browse files

ASoC: rt722-sdca: Remove logically deadcode in rt722-sdca.c 



As the same condition was checked in inner and outer if statements.
The code never reaches the inner else statement.
Fix this by removing the logically dead inner else statement.

Fixes: 7f5d6036 ("ASoC: rt722-sdca: Add RT722 SDCA driver")
Reported-by: default avatarShuah Khan <skhan@linuxfoundation.org>
Closes: https://lore.kernel.org/all/e44527e8-b7c6-4712-97a6-d54f02ad2dc9@linuxfoundation.org/


Signed-off-by: default avatarEverest K.C. <everestkc@everestkc.com.np>
Reviewed-by: default avatarShuah Khan <skhan@linuxfoundation.org>
Link: https://patch.msgid.link/20241010175755.5278-1-everestkc@everestkc.com.np


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent c1789209

sound/soc/codecs/rt722-sdca.c

+2 −6
Original line number Diff line number Diff line
@@ -607,12 +607,8 @@ static int rt722_sdca_dmic_set_gain_get(struct snd_kcontrol *kcontrol, 


		if (!adc_vol_flag) /* boost gain */

			ctl = regvalue / boost_step;

		else { /* ADC gain */

			if (adc_vol_flag)

		else /* ADC gain */

			ctl = p->max - (((vol_max - regvalue) & 0xffff) / interval_offset);

			else

				ctl = p->max - (((0 - regvalue) & 0xffff) / interval_offset);

		}



		ucontrol->value.integer.value[i] = ctl;

	}